Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/74-json-schemas #84

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Feat/74-json-schemas #84

merged 4 commits into from
Jun 10, 2024

Conversation

pogi7
Copy link
Member

@pogi7 pogi7 commented Jun 6, 2024

Checklist before submitting a merge request

Description of contribution

closes #74

Testing performed

  • I have added unit tests to cover additional functionality

How to Test Expected functionality changes

[Describe expected behaviour changes in steps]

  1. Open this repo in OML Vision https://github.com/UTNAK/kepler16b-using-imce-vocabulary
  2. Click on the eye icon to activate OML Vision
  3. Go into src/vision/commands/compositions.json
  4. Remove line 6
  5. Save the file
  6. You should see a popup or in the console saying Invalid or missing compositions.json.
  7. Undo deleting line 6
  8. Save the file
  9. You should see a popup or in the console saying compositions.json loaded successfully.
  10. Go into src/vision/config/sparqlConfig.json
  11. Remove lines 2-5
  12. Save the file
  13. You should see a popup or in the console saying Invalid or missing sparqlConfig.json.
  14. Undo deleting lines 2-5
  15. Save the file
  16. You should see a popup or in the console saying sparqlConfig.json loaded successfully.
  17. Go into src/vision/viewpoints/pages.json
  18. Remove line 3
  19. Save the file
  20. You should see a popup or in the console saying Invalid or missing pages.json.
  21. Undo deleting line 3
  22. Save the file
  23. You should see a popup or in the console saying pages.json loaded successfully.

Additional context

#83 will add to this feature

@pogi7 pogi7 requested review from UTNAK, greypilgrim and aematei June 6, 2024 00:58
Copy link
Collaborator

@aematei aematei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine until pages.json. This is what I see when I both remove and restore line 3:
Screenshot 2024-06-10 at 12 08 31 PM

@aematei
Copy link
Collaborator

aematei commented Jun 10, 2024

@pogi7 Okay I was poking around and noticed that the pages menu indeed indicates that there are no available pages to build:
image

Also, those viewpoint files in the popups I screenshot earlier seem like they are from the previous repo I was testing with...

@pogi7
Copy link
Member Author

pogi7 commented Jun 10, 2024

Everything works fine until pages.json. This is what I see when I both remove and restore line 3: Screenshot 2024-06-10 at 12 08 31 PM

@aematei VSCode only shows 3 notifications by default. The pages.json notification is not showing up. You can check the console log to verify the error.

@aematei
Copy link
Collaborator

aematei commented Jun 10, 2024

@pogi7 I checked the log and can confirm that the error is registered. I'll finish up the review.

@aematei aematei self-requested a review June 10, 2024 20:10
@aematei aematei merged commit a1a32a7 into master Jun 10, 2024
2 checks passed
@pogi7 pogi7 deleted the feat/74-json-schemas branch June 10, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON schema to viewpoint, config, and command JSON
2 participants