Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quota plugin cephfs #241

Merged
merged 17 commits into from
May 27, 2024
Merged

Quota plugin cephfs #241

merged 17 commits into from
May 27, 2024

Conversation

at88mph
Copy link
Member

@at88mph at88mph commented May 16, 2024

Minor cleanup
Added quota plugin implementation for CephFS
Yet untested, but here for draft review

Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you need to install the ubuntu attr tools in the CI build. will also need to add them to the cavern Dockerfile (in fedora it is the attr package)

while in there, it would be good to update to java 11.

@at88mph at88mph marked this pull request as ready for review May 24, 2024 05:17
Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Will aim for a release early next week.

one cosmetic change.

The error handling in the cavern PutAction is hard to evaluate and I don't know off hand how vcp will handle that exception (http 4xx code)... probably need to try it out manually

@at88mph
Copy link
Member Author

at88mph commented May 24, 2024

OK, I will test vcp today. The Checkstyle changes are complete.

@at88mph
Copy link
Member Author

at88mph commented May 24, 2024

I also had an interesting case where I reset my ceph.quota.max_bytes to something smaller to test the quota writes, but I neglected to reset the user namespace quota. When the Node loaded, it had the user namespace quota value in the NodeProperty, and wouldn't reset to the QuotaPlugin's value, hence the removal of the old value on line 548 of NodeUtil.

@pdowler
Copy link
Member

pdowler commented May 27, 2024

setting the plain quota prop in user space was a mistake (users could modify it) from previous code; we should probably manually look for and remove that user prop. the workaround is OK for now

@pdowler pdowler merged commit 000fa2a into opencadc:master May 27, 2024
1 check passed
@at88mph at88mph deleted the quota-plugin-cephfs branch May 28, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants