CADC-12563 generic PackageRunner classes for cavern and vault #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cadc-test-vos/build.gradle # cadc-test-vos/src/main/java/org/opencadc/conformance/vos/VOSTest.java # cadc-vos-server/build.gradle # cavern/build.gradle # cavern/src/main/webapp/WEB-INF/web.xml
pdowler
requested changes
Dec 12, 2023
cadc-vos-server/src/main/java/org/opencadc/vospace/server/pkg/VospacePackageRunner.java
Outdated
Show resolved
Hide resolved
cadc-vos-server/src/main/java/org/opencadc/vospace/server/pkg/VospacePackageRunner.java
Outdated
Show resolved
Hide resolved
pdowler
requested changes
Dec 20, 2023
There was a problem hiding this comment.
iterator advance()
clarify null target nodes (not found) and skip, not break
line 371: the node needs to generate the next PackageItem
line 373: do read permission check on node before nodePersistence.iterator( ) call, skip if denied
use return instead of break
…o CADC-12563-2
pdowler
requested changes
Jan 19, 2024
cadc-vos-server/src/main/java/org/opencadc/vospace/server/transfers/TransferRunner.java
Outdated
Show resolved
Hide resolved
cadc-test-vos/src/main/java/org/opencadc/conformance/vos/VOSTest.java
Outdated
Show resolved
Hide resolved
pdowler
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.