Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build + Pre-Commit Fixes #738

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Build + Pre-Commit Fixes #738

merged 7 commits into from
Nov 22, 2024

Conversation

shinybrar
Copy link
Collaborator

This pull request includes several changes to improve the build process, enhance pre-commit checks, and update documentation paths. The most important changes are grouped by theme below.

Build Process Improvements:

  • [.github/workflows/cd.edge.build.yml | cd.release.build.yml] Simplified the cosign sign command to use the build output digest and removed redundant signing commands.

Pre-Commit Configuration:

  • .pre-commit-config.yaml: Added a comprehensive pre-commit configuration file, including hooks for commit message validation, large file checks, syntax checks for various file types, and a custom Gradle build hook, etc.

Documentation Updates:

  • README.md: Corrected the paths for architecture diagram images to ensure they are correctly displayed in the documentation.

Code Formatting:

  • skaha/build.gradle: Enhanced the Spotless configuration to enforce UTF-8 encoding, format only files that differ from the main branch, and updated the Java formatting style to the latest version.

@shinybrar shinybrar requested a review from at88mph November 22, 2024 20:35
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.61%. Comparing base (12b2bf3) to head (49e246d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #738   +/-   ##
=========================================
  Coverage     18.61%   18.61%           
  Complexity      102      102           
=========================================
  Files            22       22           
  Lines          1961     1961           
  Branches        270      270           
=========================================
  Hits            365      365           
  Misses         1544     1544           
  Partials         52       52           
Flag Coverage Δ
skaha-unittests-coverage 18.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@at88mph at88mph merged commit c680510 into opencadc:main Nov 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants