Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/name duplication #34

Merged
merged 8 commits into from
Jul 20, 2022
Merged

Bug/name duplication #34

merged 8 commits into from
Jul 20, 2022

Conversation

aspirio187
Copy link
Collaborator

Description

When a new dossier with the same name as a previously one is created, the service throws an exception and the service is blocked. To overpass that I added a simple try catch, catching the right exception and simply logging to user to chose a new name

Fixes #21

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Firmware version: Ubuntu 22.04 LTS
  • Hardware:
  • Toolchain: VSCode
  • SDK: .NET 6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aspirio187 aspirio187 added the bug Something isn't working label Jul 20, 2022
@aspirio187 aspirio187 requested a review from nbittich July 20, 2022 08:27
@aspirio187 aspirio187 self-assigned this Jul 20, 2022
@aspirio187 aspirio187 merged commit 1c5b061 into develop Jul 20, 2022
@aspirio187 aspirio187 deleted the bug/name-duplication branch July 20, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name duplication
2 participants