Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected filename generation before saving in Dropbox #24

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

aspirio187
Copy link
Collaborator

Description

When a dossier was closed and sent to Dropbox its extension was missing. It was due to an error during Dropbox file name generation.

string dropboxFileName = GenerateDropboxFileName(dossierName, createdAt); The parameter dossierName was incorrect and has been chanegd to the correct file name like this : string dropboxFileName = GenerateDropboxFileName(fileName, createdAt);

Fixes #17

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This fix has been tested by closing a dossier and verifying in Dropbox the file name

  • Close dossier

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain: VSCode
  • SDK: .NET 6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aspirio187 aspirio187 added the bug Something isn't working label Jun 21, 2022
@aspirio187 aspirio187 requested a review from nbittich June 21, 2022 08:59
@aspirio187 aspirio187 self-assigned this Jun 21, 2022
@aspirio187 aspirio187 merged commit 34e4883 into develop Jun 21, 2022
@aspirio187 aspirio187 deleted the bug/active-dossier-extension-missing branch June 21, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

active dossier closed: extension seems missing in the zip
2 participants