Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update servicelinker.json #3679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update servicelinker.json #3679

wants to merge 1 commit into from

Conversation

raych1
Copy link

@raych1 raych1 commented Oct 31, 2023

No description provided.

Copy link

No pipelines are associated with this pull request.

@JackTn
Copy link

JackTn commented Nov 1, 2023

/azp run

Copy link

No pipelines are associated with this pull request.

Copy link

Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
servicelinker.json 2022-05-01(b897200) 2022-05-01(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2022-05-01 package-2022-05-01(b897200) package-2022-05-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'linkerName' should be defined with a 'pattern' restriction.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L74
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L168
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L201
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L212
LroPatch202 The async patch operation should return 202.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L247
ResourceNameRestriction The resource name parameter 'linkerName' should be defined with a 'pattern' restriction.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L269
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L303
ResourceNameRestriction The resource name parameter 'linkerName' should be defined with a 'pattern' restriction.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L315
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L52
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L65
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L88
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L104
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L132
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L163
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L188
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L207
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L232
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L263
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'validatelinker' in:'Linker_Validate'. Consider updating the operationId
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L274
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L290
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L309
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L332
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L348
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetConfiguration
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L361
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L368
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L375
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L381
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L475
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L742
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L758
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌ModelValidation: 4 Errors, 0 Warnings failed [Detail]
Rule Message
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L737:23
ExampleUrl: stable/2022-05-01/examples/PutLink.json#L25:15
MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L737:23
ExampleUrl: stable/2022-05-01/examples/PutLink.json#L41:15
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L194:22
ExampleUrl: stable/2022-05-01/examples/DeleteLink.json
LRO_RESPONSE_HEADER Long running operation should return location or azure-AsyncOperation in header but not provided
Url: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L296:22
ExampleUrl: stable/2022-05-01/examples/ValidateLinkSuccess.json
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️~[NotRequired_Staging] TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️[NotRequired_Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[NotRequired_Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation

  • The following tags are being changed in this PR
    • "https://github.com/openapi-env-test/azure-rest-api-specs/blob/b8972008e1c77fc500c643ea1fb237e4c068f61b/specification/servicelinker/resource-manager/readme.md#tag-package-2022-05-01">servicelinker/resource-manager/readme.md#package-2022-05-01
The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Swagger Generation Artifacts

️🔄[NotRequired_Staging] ApiDocPreview inProgress [Detail]
️❌[NotRequired_Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/servicelinker/armservicelinker - 2.0.0
+	Function `*ClientFactory.NewLinkerClient` has been removed
+	Function `*ClientFactory.NewOperationsClient` has been removed
+	Function `NewClientFactory` has been removed
+	Struct `ClientFactory` has been removed
+	Type of `ErrorAdditionalInfo.Info` has been changed from `any` to `interface{}`


️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 9207280. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️track2_azure-mgmt-servicelinker [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 9207280. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-servicelinker [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 9207280. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/servicelinker/armservicelinker [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `ErrorAdditionalInfo.Info` has been changed from `any` to `interface{}`
    info	[Changelog] - Function `NewClientFactory` has been removed
    info	[Changelog] - Function `*ClientFactory.NewLinkerClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewOperationsClient` has been removed
    info	[Changelog] - Struct `ClientFactory` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ClientTypeKafkaSpringBoot` added to type alias `ClientType`
    info	[Changelog]
    info	[Changelog] Total 6 breaking change(s), 1 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 9207280. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-servicelinker [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Enum KnownClientType has a new value KafkaSpringBoot
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Copy link

No pipelines are associated with this pull request.

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️🔄LintDiff inProgress [Detail]
️️✔️PR Summary succeeded [Detail] [Expand]
️🔄[NotRequired_Staging] Lint(RPaaS) inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️🔄ModelValidation inProgress [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SwaggerAPIView succeeded [Detail] [Expand]
️️✔️~[NotRequired_Staging] TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️[NotRequired_Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️🔄[NotRequired_Staging] SDK Track2 Validation inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

Swagger Generation Artifacts

️🔄[NotRequired_Staging] ApiDocPreview inProgress [Detail]
️❌[NotRequired_Staging] SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/servicelinker/armservicelinker - 2.0.0
+	Function `*ClientFactory.NewLinkerClient` has been removed
+	Function `*ClientFactory.NewOperationsClient` has been removed
+	Function `NewClientFactory` has been removed
+	Struct `ClientFactory` has been removed
+	Type of `ErrorAdditionalInfo.Info` has been changed from `any` to `interface{}`


️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️🔄 azure-sdk-for-python-track2 inProgress [Detail]
️🔄 azure-sdk-for-java inProgress [Detail]
️🔄 azure-sdk-for-go inProgress [Detail]
️🔄 azure-sdk-for-js inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-dev-app-jacktn bot commented Nov 1, 2023

@JackTn JackTn added the APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. label Nov 1, 2023
@JackTn
Copy link

JackTn commented Nov 1, 2023

123

@JackTn
Copy link

JackTn commented Nov 1, 2023

/azp run

Copy link

No pipelines are associated with this pull request.

@raych1
Copy link
Author

raych1 commented Nov 6, 2023

/azp run

Copy link

No pipelines are associated with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants