Skip geometries for points that have NaN coords

openaddresses · Sep 10, 2016 · 3729050 · 3729050
1 parent 4c7f076
commit 3729050
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/esridump/esri2geojson.py b/esridump/esri2geojson.py
@@ -1,4 +1,5 @@
 from itertools import tee
+import math
 
 def esri2geojson(esrijson_feature):
     response = dict(type="Feature", geometry=None, properties=None)
@@ -29,7 +30,7 @@ def convert_esri_point(esri_geometry):
     x_coord = esri_geometry.get('x')
     y_coord = esri_geometry.get('y')
 
-    if x_coord and y_coord:
+    if x_coord and y_coord and not math.isnan(x_coord) and not math.isnan(y_coord):
         return {
             "type": "Point",
             "coordinates": [x_coord, y_coord]

diff --git a/tests/esrijson_tests.py b/tests/esrijson_tests.py
@@ -94,6 +94,36 @@ def test_empty_point(self):
             }
         )
 
+    def test_nan_point(self):
+        self.assertEsriJsonBecomesGeoJson(
+            {
+                "geometry": {
+                    "x": float('nan'),
+                    "y": float('nan'),
+                },
+            },
+
+            {
+                "type": "Feature",
+                "properties": None,
+                "geometry": None
+            }
+        )
+
+        self.assertEsriJsonBecomesGeoJson(
+            {
+                "geometry": {
+                    "points": [float('nan'), float('nan')]
+                },
+            },
+
+            {
+                "type": "Feature",
+                "properties": None,
+                "geometry": None
+            }
+        )
+
 
 class TestGeoJsonLinestringConversion(TestEsriJsonToGeoJson):
     def test_linestring(self):