Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new HTTP semantic convention opt-in for Falcon #2790

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2d68dc5
Implement new HTTP semantic convention opt-in for Falcon
FilipNikolovski Aug 9, 2024
228897d
fix tests for falcon 1 & 2
FilipNikolovski Aug 9, 2024
2d70a72
resolve conflicts
FilipNikolovski Dec 2, 2024
a9a30a8
add semconv status as migration for falcon in instrumentations readme
FilipNikolovski Dec 2, 2024
b3db908
set schema_url based on the opt-in mode
FilipNikolovski Dec 2, 2024
aa54865
add histograms based on opt-in mode; set metrics attributes; update t…
FilipNikolovski Dec 2, 2024
2ed1461
run ruff
FilipNikolovski Dec 2, 2024
e8d3e6c
disable too-many-public-methods lint rule for TestFalconInstrumentation
FilipNikolovski Dec 2, 2024
d1e81c0
Merge branch 'main' into falcon_new_semconv
FilipNikolovski Dec 3, 2024
1815495
add _semconv_status in package.py
FilipNikolovski Dec 3, 2024
0307008
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
FilipNikolovski Dec 3, 2024
a4419a6
Merge branch 'main' into falcon_new_semconv
emdneto Dec 3, 2024
7754f0d
cleanup imports
FilipNikolovski Dec 10, 2024
b941569
set request attributes in env, set status code in metric attributes i…
FilipNikolovski Dec 10, 2024
e14eaf9
Merge branch 'main' into falcon_new_semconv
FilipNikolovski Dec 10, 2024
c44244c
fix exceptions to not be masked as 500 on every thrown exception
FilipNikolovski Dec 10, 2024
1cecee6
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
FilipNikolovski Dec 10, 2024
59586fd
resolve lint issues
FilipNikolovski Dec 10, 2024
6ac9e98
run tox -e generate; fix typo
FilipNikolovski Dec 10, 2024
d0757ec
Merge branch 'main' into falcon_new_semconv
emdneto Dec 16, 2024
2d6b160
sort imports
FilipNikolovski Dec 31, 2024
ecd351f
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
FilipNikolovski Dec 31, 2024
3d5ec55
fix tests
FilipNikolovski Dec 31, 2024
e51f79d
Merge branch 'open-telemetry:main' into falcon_new_semconv
FilipNikolovski Dec 31, 2024
bfb8a53
Merge branch 'main' of https://github.com/FilipNikolovski/opentelemet…
FilipNikolovski Dec 31, 2024
606958a
update changelog
FilipNikolovski Dec 31, 2024
6ee7d35
Merge branch 'falcon_new_semconv' of https://github.com/FilipNikolovs…
FilipNikolovski Dec 31, 2024
e12ace6
Merge branch 'main' into falcon_new_semconv
FilipNikolovski Jan 2, 2025
8b281b2
update tests
FilipNikolovski Jan 2, 2025
c662eae
disable lint check on too-many-nested-blocks in metrics test
FilipNikolovski Jan 2, 2025
7702a59
use add_response_attributes function from wsgi
FilipNikolovski Jan 3, 2025
174e144
resolve conflicts
FilipNikolovski Jan 3, 2025
241a849
cleanup unused functions
FilipNikolovski Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,7 @@ def process_response(self, req, resp, resource, req_succeeded=None): # pylint:d
if exc_type and not req_succeeded:
if "HTTPNotFound" in exc_type.__name__:
status = "404"
elif isinstance(exc, falcon.HTTPError) or isinstance(
exc, falcon.HTTPStatus
):
elif isinstance(exc, falcon.HTTPError, falcon.HTTPStatus):
xrmx marked this conversation as resolved.
Show resolved Hide resolved
try:
status = exc.title.split(" ")[0]
except ValueError:
Expand Down
Loading