Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow broad exceptions in pylint #2471

Closed
wants to merge 6 commits into from
Closed

Allow broad exceptions in pylint #2471

wants to merge 6 commits into from

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Apr 27, 2024

Fixes #2470

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 27, 2024
@ocelotl ocelotl self-assigned this Apr 27, 2024
@ocelotl ocelotl requested a review from a team April 27, 2024 21:42
xrmx
xrmx reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion, but why not keeping the check and just use builtins.Exception in the config?

@ocelotl
Copy link
Contributor Author

ocelotl commented May 2, 2024

No strong opinion, but why not keeping the check and just use builtins.Exception in the config?

So, I tried this approach because it was the one that worked for the core repo.

@ocelotl ocelotl requested a review from xrmx May 6, 2024 16:52
xrmx
xrmx requested changes May 9, 2024
View reviewed changes
.pylintrc Show resolved Hide resolved
@ocelotl ocelotl requested a review from xrmx May 14, 2024 21:08
xrmx
xrmx reviewed May 14, 2024
View reviewed changes
.pylintrc Show resolved Hide resolved
@ocelotl ocelotl requested a review from xrmx May 21, 2024 00:50
@ocelotl
Copy link
Contributor Author

ocelotl commented Jun 28, 2024

Closing in favor of #2536

@ocelotl ocelotl closed this Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx Awaiting requested review from xrmx

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix warning when running lint
2 participants
@ocelotl @xrmx