-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bit of warnings and deprecations #315
base: main
Are you sure you want to change the base?
Conversation
TraceAttributes::DB_OPERATION => $operationName, | ||
TraceAttributes::DB_NAMESPACE => $query->connection->getDatabaseName(), | ||
TraceAttributes::DB_OPERATION_NAME => $operationName, | ||
/** @phan-suppress-next-line PhanDeprecatedClassConstant */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what to do if there is no replacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess drop it is the best option
These changes look sensible, but I suspect that the semantic convention ones will run into the moratorium on changing produced telemetry. I don't fully understand the reasoning, but it's becoming a real pain for us: we created a bunch of packages (auto-instrumentation and such) at around semconv 1.24/1.25, and those packages are seemingly stuck on those versions until that moratorium is lifted. But in the meantime, new semconv versions have been released which deprecate some of those semconvs, and our static analysis tools complain. |
No description provided.