Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bit of warnings and deprecations #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

intuibase
Copy link
Contributor

No description provided.

@intuibase intuibase requested a review from a team as a code owner November 5, 2024 16:28
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 73.54%. Comparing base (27a188b) to head (f8f40cb).

Files with missing lines Patch % Lines
src/Context/Swoole/src/SwooleContextStorage.php 0.00% 3 Missing ⚠️
.../src/Watchers/RedisCommand/RedisCommandWatcher.php 0.00% 3 Missing ⚠️
...vel/src/Hooks/Illuminate/Contracts/Queue/Queue.php 50.00% 1 Missing ⚠️
...c/Instrumentation/Psr3/src/Psr3Instrumentation.php 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (27a188b) and HEAD (f8f40cb). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (27a188b) HEAD (f8f40cb)
Propagation/TraceResponse 1 0
Instrumentation/CakePHP 1 0
Instrumentation/Psr14 1 0
Shims/OpenTracing 1 0
Instrumentation/HttpAsyncClient 1 0
Instrumentation/Psr18 1 0
Instrumentation/PDO 1 0
Instrumentation/Symfony 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #315      +/-   ##
============================================
- Coverage     79.12%   73.54%   -5.58%     
- Complexity      676      677       +1     
============================================
  Files            67       77      +10     
  Lines          2822     2741      -81     
============================================
- Hits           2233     2016     -217     
- Misses          589      725     +136     
Flag Coverage Δ
Aws 85.55% <ø> (ø)
Context/Swoole 0.00% <0.00%> (?)
Instrumentation/CakePHP ?
Instrumentation/CodeIgniter 73.77% <ø> (ø)
Instrumentation/Curl 91.02% <ø> (ø)
Instrumentation/ExtRdKafka 87.73% <100.00%> (?)
Instrumentation/Guzzle 69.51% <ø> (ø)
Instrumentation/HttpAsyncClient ?
Instrumentation/IO 70.68% <ø> (ø)
Instrumentation/Laravel 61.98% <63.63%> (?)
Instrumentation/MongoDB 76.31% <ø> (ø)
Instrumentation/OpenAIPHP 87.31% <ø> (ø)
Instrumentation/PDO ?
Instrumentation/Psr14 ?
Instrumentation/Psr15 93.82% <ø> (ø)
Instrumentation/Psr16 97.56% <ø> (ø)
Instrumentation/Psr18 ?
Instrumentation/Psr3 59.49% <0.00%> (?)
Instrumentation/Psr6 97.67% <ø> (ø)
Instrumentation/Slim 86.89% <ø> (ø)
Instrumentation/Symfony ?
Instrumentation/Yii 77.68% <ø> (ø)
Logs/Monolog 100.00% <100.00%> (?)
Propagation/ServerTiming 100.00% <ø> (ø)
Propagation/TraceResponse ?
ResourceDetectors/Azure 91.66% <100.00%> (?)
ResourceDetectors/Container 93.02% <ø> (ø)
Sampler/RuleBased 33.51% <ø> (ø)
Shims/OpenTracing ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/ExtRdKafka/src/ExtRdKafkaInstrumentation.php 87.73% <100.00%> (ø)
...tion/Laravel/src/Hooks/Illuminate/Queue/Worker.php 26.31% <100.00%> (ø)
...nstrumentation/Laravel/src/Watchers/LogWatcher.php 94.73% <100.00%> (ø)
...trumentation/Laravel/src/Watchers/QueryWatcher.php 95.83% <100.00%> (ø)
...n/Laravel/src/Watchers/RedisCommand/Serializer.php 92.30% <100.00%> (ø)
src/Logs/Monolog/src/Handler.php 100.00% <100.00%> (ø)
...esourceDetectors/Azure/src/AppService/Detector.php 95.00% <100.00%> (ø)
...vel/src/Hooks/Illuminate/Contracts/Queue/Queue.php 69.66% <50.00%> (ø)
...c/Instrumentation/Psr3/src/Psr3Instrumentation.php 47.54% <0.00%> (ø)
src/Context/Swoole/src/SwooleContextStorage.php 0.00% <0.00%> (ø)
... and 1 more

... and 45 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a188b...f8f40cb. Read the comment docs.

TraceAttributes::DB_OPERATION => $operationName,
TraceAttributes::DB_NAMESPACE => $query->connection->getDatabaseName(),
TraceAttributes::DB_OPERATION_NAME => $operationName,
/** @phan-suppress-next-line PhanDeprecatedClassConstant */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what to do if there is no replacement

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess drop it is the best option

@brettmc
Copy link
Collaborator

brettmc commented Nov 7, 2024

These changes look sensible, but I suspect that the semantic convention ones will run into the moratorium on changing produced telemetry.

I don't fully understand the reasoning, but it's becoming a real pain for us: we created a bunch of packages (auto-instrumentation and such) at around semconv 1.24/1.25, and those packages are seemingly stuck on those versions until that moratorium is lifted. But in the meantime, new semconv versions have been released which deprecate some of those semconvs, and our static analysis tools complain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants