Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported versions in 2.0 README #5287

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

chancancode
Copy link
Contributor

  • Includes a cherry-pick for chore: updated v1.x supported versions #5286
  • Synced supported Node versions (for v2.0)
  • Also deleted a very old comment about Node 8 being required. Node 8 was EOL in 2019, it seems extremely unlikely that the perf_hook is the only thing preventing the SDK from working in extremely old versions at this point.

Also deleted a very old comment about Node 8 being required. Node
8 was EOL in 2019, it seems extremely unlikely that the `perf_hook`
is the _only_ thing preventing the SDK from working in extremely
old versions at this point.
@chancancode chancancode requested a review from a team as a code owner December 19, 2024 02:42
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (107637e) to head (cb8d52b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5287      +/-   ##
==========================================
- Coverage   94.64%   94.63%   -0.02%     
==========================================
  Files         323      323              
  Lines        8084     8084              
  Branches     1643     1643              
==========================================
- Hits         7651     7650       -1     
- Misses        433      434       +1     

see 1 file with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙌

@pichlermarc pichlermarc added Skip Changelog document Documentation-related labels Dec 19, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Dec 19, 2024
Merged via the queue into open-telemetry:main with commit 347dd5f Dec 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants