Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed circular dependency from BasicTracerProvider #5279

Conversation

MingaudasVagonis
Copy link
Contributor

Which problem is this PR solving?

Removing a circular dependency in opentelemetry-sdk-trace-base BasicTracerProvider.ts which was causing an error on React Native/Babel:
Cannot read property 'prototype' of undefined

Simply changed it to direct import, should not be an issue on other platforms.

Short description of the changes

Changed the import from '.' to './Tracer' and './SpanProcessor'.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Retried getting a Tracer with the changes and the error was not there anymore, Tracer worked correctly.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@MingaudasVagonis MingaudasVagonis marked this pull request as ready for review December 17, 2024 20:43
@MingaudasVagonis MingaudasVagonis requested a review from a team as a code owner December 17, 2024 20:43
@pichlermarc pichlermarc added this pull request to the merge queue Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (8ab52d5) to head (b951f06).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5279      +/-   ##
==========================================
+ Coverage   94.66%   94.67%   +0.01%     
==========================================
  Files         322      322              
  Lines        8058     8058              
  Branches     1632     1632              
==========================================
+ Hits         7628     7629       +1     
+ Misses        430      429       -1     
Files with missing lines Coverage Δ
...elemetry-sdk-trace-base/src/BasicTracerProvider.ts 95.68% <100.00%> (ø)

... and 1 file with indirect coverage changes

Merged via the queue into open-telemetry:main with commit e524148 Dec 18, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants