Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): adapt workflow to use supported npm versions #5277

Merged
merged 4 commits into from
Dec 17, 2024
+7 −3
Merged

fix(ci): adapt workflow to use supported npm versions #5277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70d66ba
fix(ci): adapt workflow to use correct npm versions
pichlermarc Dec 17, 2024
aabc68f
fixup! fix(ci): adapt workflow to use correct npm versions
pichlermarc Dec 17, 2024
7279610
fixup! fix(ci): adapt workflow to use correct npm versions
pichlermarc Dec 17, 2024
41a1ef3
fixup! fix(ci): adapt workflow to use correct npm versions
pichlermarc Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
node_version:
- "18"
- "22"
runs-on: self-hosted
timeout-minutes: 10
env:
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,16 @@ jobs:
node-version: ${{ matrix.node_version }}

- run: npm install -g npm@latest
if: ${{ matrix.node_version == '18' || matrix.node_version == '20' || matrix.node_version == '22' }}
if: ${{ matrix.node_version == '20' || matrix.node_version == '22' }}

# [email protected] drops support for Node.js v14 and v16
- run: npm install -g npm@"<10.0.0"
if: ${{ matrix.node_version == '14' || matrix.node_version == '16' }}

# [email protected] drops support for Node.js v18
- run: npm install -g npm@"<11.0.0"
if: ${{ matrix.node_version == '18'}}

- name: Bootstrap
run: npm ci

Expand Down Expand Up @@ -65,7 +69,7 @@ jobs:
cache: 'npm'
cache-dependency-path: |
package-lock.json
node-version: '18'
node-version: '20'

- run: npm install -g npm@latest

Expand Down
Loading