Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(otlp-transformer): re-structure package to prepare for separate entrypoints #5264

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Dec 13, 2024

Which problem is this PR solving?

Important

This is a refactor, I only moved code, but the logic has not changed.

I'm planning to re-structure the exporters to have seperate entrypoints. This solves some issues with rollup, that warns even for code that is dead in the end-user's app. See #5216

The planned structure of the entrypoints for each signal is:

  • /signal, /signal/protobuf, singal/json

To make this change easier to review, I've opened this PR, which just moves code into the correct place so that we can add the entypoints in #5263

Prepares for #5263

Type of change

  • Internal Refactor

How Has This Been Tested?

  • Unit tests

@pichlermarc pichlermarc changed the title refactor(otlp-transformer): re-struture package to prepare for separate entrypoints refactor(otlp-transformer): re-structure package to prepare for separate entrypoints Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (6d31a18) to head (2bcd3b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5264      +/-   ##
==========================================
- Coverage   94.67%   94.66%   -0.02%     
==========================================
  Files         315      322       +7     
  Lines        8057     8058       +1     
  Branches     1632     1632              
==========================================
  Hits         7628     7628              
- Misses        429      430       +1     
Files with missing lines Coverage Δ
...l/packages/otlp-transformer/src/common/internal.ts 100.00% <100.00%> (ø)
...ntal/packages/otlp-transformer/src/common/utils.ts 100.00% <ø> (ø)
...ckages/otlp-transformer/src/logs/internal-types.ts 100.00% <ø> (ø)
...tal/packages/otlp-transformer/src/logs/internal.ts 100.00% <100.00%> (ø)
...l/packages/otlp-transformer/src/logs/json/index.ts 100.00% <100.00%> (ø)
...al/packages/otlp-transformer/src/logs/json/logs.ts 100.00% <100.00%> (ø)
...ckages/otlp-transformer/src/logs/protobuf/index.ts 100.00% <100.00%> (ø)
...ackages/otlp-transformer/src/logs/protobuf/logs.ts 100.00% <100.00%> (ø)
...ges/otlp-transformer/src/metrics/internal-types.ts 100.00% <ø> (ø)
.../packages/otlp-transformer/src/metrics/internal.ts 100.00% <100.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review December 13, 2024 13:51
@pichlermarc pichlermarc requested a review from a team as a code owner December 13, 2024 13:51
@pichlermarc pichlermarc added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Dec 13, 2024
Merged via the queue into open-telemetry:main with commit 84cce75 Dec 13, 2024
21 checks passed
@pichlermarc pichlermarc deleted the refactor/restructure-otlp-transformer branch December 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants