Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update prettier to 3.4.2 #5261

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

chancancode
Copy link
Contributor

Which problem is this PR solving?

Update prettier to the latest version

No one asked for this, I ran into a small issue. (It was small enough that after all of this I forgot what it was, sorry.) Upgrading fixed the issue, and didn't require any changes, so here is the PR.

Short description of the changes

  • Upgrade prettier
  • npm install
  • npm run lint:fix/npm run lint (no changes)

Type of change

Please delete options that are not relevant.

  • Internal chore
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • npm run lint:fix/npm run lint (no changes)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

ran lint/lint:fix, no formatting changes necessary
@chancancode chancancode requested a review from a team as a code owner December 13, 2024 02:29
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (e4d9c21) to head (dac2cfc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5261      +/-   ##
==========================================
- Coverage   94.67%   94.65%   -0.02%     
==========================================
  Files         315      315              
  Lines        8012     8012              
  Branches     1617     1617              
==========================================
- Hits         7585     7584       -1     
- Misses        427      428       +1     

see 1 file with indirect coverage changes

@pichlermarc
Copy link
Member

thanks :)

@pichlermarc pichlermarc added this pull request to the merge queue Dec 13, 2024
Merged via the queue into open-telemetry:main with commit e03b6e7 Dec 13, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants