-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: update typescript to version 5.0.4
#5145
base: main
Are you sure you want to change the base?
Changes from all commits
f0933b9
8d8ea7c
08d14f7
73422ec
40d4587
8f4220c
0695015
1db53a3
7dfbae7
780830e
268bf92
6fe7953
87f231f
703f0ab
c46c11b
7d71e92
8ce75a9
8eca42c
517790c
04391c7
8b6e408
af2f2b0
9d74bb9
36c084c
7c5e895
920c2c3
bb7568d
d26fbd2
b7580fb
991280b
a4e30a7
e01cd50
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -203,6 +203,15 @@ cd packages/opentelemetry-module-name | |
npm run watch | ||
``` | ||
|
||
#### TypeScript version & update policy | ||
|
||
TypeScript version used to compile the pacakges is `v5.0.4`. If you plan to use any of the packages from this | ||
repository to make your own application or package instrumentation make sure to use same version or higher. | ||
|
||
<!-- Ref: https://github.com/open-telemetry/opentelemetry-js/pull/5145#issuecomment-2518263890 --> | ||
As update policy OpenTelemetry JS will follow DefinitelyType's [support policy for TypeScript](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) | ||
which sets a support window of 2 years. | ||
|
||
Comment on lines
+206
to
+214
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It may be good to have this be more visible by also stating something similar in README.md - while it's important for contributors to know how we're using typescript, there's an effect on end-users that we should communicate. 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be e01cd50 enough? |
||
### Running tests | ||
|
||
Similar to compilations, tests can be run from the root to run all tests or from a single module to run only the tests for that module. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for reviewer: TypeScript 5.0+ removes support for Node.js <=12.0