Fix NaN and Infinity values in logs being coerced into null and causing exception in OTEL collector

[witoszekdev]

Which problem is this PR solving?

OpenTelemetry JS logging SDK had a bug where if the log had a NaN, Infinity or -Infinity value, it was treated as a number and returned

{
  doubleValue: null;
}

to Collector, which caused an exception.

Short description of the changes

This PR uses Number.isFinite method to check if the value is in fact a number, and won't be coerced into null by JSON.stringify.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: witoszekdev / name: Jonatan Witoszek (fce57da, 29bc0bf)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (4655895) to head (f17141b).
Report is 146 commits behind head on main.

❗ Current head f17141b differs from pull request most recent head 29bc0bf

Please upload reports for the commit 29bc0bf to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4435      +/-   ##
==========================================
- Coverage   92.23%   92.23%   -0.01%     
==========================================
  Files         336      336              
  Lines        9533     9525       -8     
  Branches     2022     2020       -2     
==========================================
- Hits         8793     8785       -8     
  Misses        740      740              

Files	Coverage Δ
...l/packages/otlp-transformer/src/common/internal.ts	100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

[dyladan]

Fix seems straightforward enough, but it seems to me that we are dropping important information here. Is NaN and Infinity really not representable? Is this only affecting JSON or does it also affect protobuf? If it is JSON only, it should be handled somewhere that it doesn't affect the protobuf version, similar to how trace and span ids are handled.

[pichlermarc]

This code is also used for protobuf where it's possible to represent both NaN and +/-Infinity.
As @dyladan said, we're likely loosing some data here and we need to ensure we don't affect the protobuf exporters with this change.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.