-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: transpile zone.js products in test #4423
Conversation
892f8b9
to
ea1aaa5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
- Coverage 92.19% 91.94% -0.26%
==========================================
Files 336 278 -58
Lines 9512 6802 -2710
Branches 2016 1390 -626
==========================================
- Hits 8770 6254 -2516
+ Misses 742 548 -194
|
@@ -49,6 +49,7 @@ | |||
}, | |||
"devDependencies": { | |||
"@babel/core": "7.23.6", | |||
"@babel/preset-env": "7.22.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do we need this here? 🤔
The gRPC exporter only supports Node.js so we never use it right? 🤔 We may also be able to drop @babel/core
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, yeah, thank you for spotting this. Unnecessary test dependencies removed.
ea1aaa5
to
541b5e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙂
Which problem is this PR solving?
Test with zone.js' default export entry rather than specifying
'zone.js/dist/index'
Short description of the changes
Zone.js' default export entry that is picked by the bundler contains new syntax that needs to be transpiled.
Type of change
Checklist: