Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-metrics)!: remove MeterProvider.addMetricReader() in favor of constructor option #4419

Merge branch 'next' into feat/remove-addmetricreader

0be7c90
Select commit
Loading
Failed to load commit list.
Merged

feat(sdk-metrics)!: remove MeterProvider.addMetricReader() in favor of constructor option #4419

Merge branch 'next' into feat/remove-addmetricreader
0be7c90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2024 in 0s

92.27% (+0.03%) compared to 543f0b4

View this Pull Request on Codecov

92.27% (+0.03%) compared to 543f0b4

Details

Codecov Report

Merging #4419 (0be7c90) into next (543f0b4) will increase coverage by 0.03%.
Report is 8 commits behind head on next.
The diff coverage is 96.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4419      +/-   ##
==========================================
+ Coverage   92.24%   92.27%   +0.03%     
==========================================
  Files         332      332              
  Lines        9437     9436       -1     
  Branches     1999     1996       -3     
==========================================
+ Hits         8705     8707       +2     
+ Misses        732      729       -3     
Files Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 93.75% <100.00%> (+0.20%) ⬆️
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.75% <100.00%> (+0.83%) ⬆️
...imental/packages/opentelemetry-sdk-node/src/sdk.ts 92.80% <100.00%> (+0.05%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.23% <100.00%> (ø)
...mental/packages/otlp-transformer/src/logs/index.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.05% <100.00%> (+0.07%) ⬆️
...ckages/opentelemetry-core/src/common/attributes.ts 93.18% <100.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes