feat(instrumentation): make InstrumentationAbstract.init public #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4418 +/- ##
==========================================
- Coverage 92.37% 90.81% -1.56%
==========================================
Files 304 87 -217
Lines 8682 1906 -6776
Branches 1831 405 -1426
==========================================
- Hits 8020 1731 -6289
+ Misses 662 175 -487 |
dyladan
approved these changes
Jan 31, 2024
pichlermarc
approved these changes
Jan 31, 2024
experimental/packages/opentelemetry-instrumentation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
pichlermarc
changed the title
pichlermarc
approved these changes
Feb 1, 2024
|
@pichlermarc could you merge when you get a moment? thanks! |
3 tasks
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…-telemetry#4418) * Make InstrumentationAbstract.init public * Update changelog * Update JSDoc --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
For the esbuild instrumentation plugin I'm attempting to rely on
.init()at build time to get info about instrumentations, and in order for that to typecheck I need public access to this method.Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Compile this package and use it in that plugin (locally).
In this repo:
npm run compilecd experimental/packages/opentelemetry-instrumentationnpm packIn my fork of the
opentelemetry-js-contribon theesbuild-pluginbranch (which is in the same directory asopentelemetry-js)cd packages/esbuild-plugin-nodenpm i ../../../opentelemetry-js/experimental/packages/opentelemetry-instrumentation-grpc/opentelemetry-instrumentation-0.47.0.tgzChecklist: