Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otel-core): replace deprecated SpanAttributes #4408

Merged

Conversation

JamieDanielson
Copy link
Member

@JamieDanielson JamieDanielson commented Jan 9, 2024

Which problem is this PR solving?

Short description of the changes

  • Update minimum API version to 1.1.0 in opentelemetry-core
  • Replace deprecated SpanAttributes and SpanAttributeValue with Attributes and AttributeValue respectively

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Unit tests pass

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been updated

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #4408 (01f0878) into next (543f0b4) will increase coverage by 0.02%.
Report is 5 commits behind head on next.
The diff coverage is 94.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4408      +/-   ##
==========================================
+ Coverage   92.24%   92.27%   +0.02%     
==========================================
  Files         332      332              
  Lines        9437     9434       -3     
  Branches     1999     1995       -4     
==========================================
  Hits         8705     8705              
+ Misses        732      729       -3     
Files Coverage Δ
...erimental/packages/api-logs/src/types/LogRecord.ts 100.00% <ø> (ø)
...porter-metrics-otlp-grpc/src/OTLPMetricExporter.ts 93.75% <100.00%> (+0.20%) ⬆️
...-otlp-http/src/platform/node/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...orter-metrics-otlp-proto/src/OTLPMetricExporter.ts 100.00% <100.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts 94.75% <100.00%> (+0.83%) ⬆️
...ackages/otlp-exporter-base/src/OTLPExporterBase.ts 95.23% <100.00%> (ø)
...mental/packages/otlp-transformer/src/logs/index.ts 100.00% <ø> (ø)
experimental/packages/sdk-logs/src/LogRecord.ts 98.05% <100.00%> (+0.07%) ⬆️
...ckages/opentelemetry-core/src/common/attributes.ts 93.18% <100.00%> (ø)
...metry-core/src/trace/sampler/ParentBasedSampler.ts 83.87% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@JamieDanielson JamieDanielson marked this pull request as ready for review January 9, 2024 23:46
@JamieDanielson JamieDanielson requested a review from a team January 9, 2024 23:46
@JamieDanielson
Copy link
Member Author

This targets the Next branch, I'm not sure what to put in changelog or where this should be noted though!

@trentm
Copy link
Contributor

trentm commented Jan 10, 2024

I'm not sure what to put in changelog or where this should be noted though!

@dyladan created https://github.com/open-telemetry/opentelemetry-js/blob/next/CHANGELOG_NEXT.md for that, IIUC.

@JamieDanielson JamieDanielson self-assigned this Jan 10, 2024
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a nit

packages/opentelemetry-core/package.json Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit 7f613e0 into open-telemetry:next Jan 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants