-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(otel-core): replace deprecated SpanAttributes #4408
chore(otel-core): replace deprecated SpanAttributes #4408
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #4408 +/- ##
==========================================
+ Coverage 92.24% 92.27% +0.02%
==========================================
Files 332 332
Lines 9437 9434 -3
Branches 1999 1995 -4
==========================================
Hits 8705 8705
+ Misses 732 729 -3
|
This targets the Next branch, I'm not sure what to put in changelog or where this should be noted though! |
@dyladan created https://github.com/open-telemetry/opentelemetry-js/blob/next/CHANGELOG_NEXT.md for that, IIUC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a nit
Which problem is this PR solving?
SpanAttributes
/MetricAttributes
withAttributes
#4175Short description of the changes
SpanAttributes
andSpanAttributeValue
withAttributes
andAttributeValue
respectivelyType of change
How Has This Been Tested?
Checklist: