Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ensure deploy workflow does not override benchmark data #4376

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Currently out docs deploy workflow deletes the pre-existing benchmark data from the benchmarks/ directory from the gh-pages branch (see 6cf6b67, b3a3d45).

To fix this, this PR:

  • adds the clean-exclude option with benchmarks/** to ensure they are not deleted when the other docs data is rsynced by the action.
  • updates the deploy action to v4 (at least v4.2.0 is needed for wildcard matching in clean-exclude)
  • updates the node version used in the workflow to v20 (so that we can use v4 of the deploy action)

How Has This Been Tested?

  • Ran the workflow in a private repo where I pushed both the main and gh-pages branch.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #4376 (cf45bdd) into main (3e59291) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4376   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         332      332           
  Lines        9467     9467           
  Branches     2011     2011           
=======================================
  Hits         8731     8731           
  Misses        736      736           

with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore as the action uses the default authentication since v4.

@pichlermarc pichlermarc merged commit 37add77 into open-telemetry:main Dec 18, 2023
21 of 22 checks passed
@pichlermarc pichlermarc deleted the fix/deploy-workflow-benchmark branch December 18, 2023 16:58
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants