Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-logs): await async resources in log processors #4349

Merged
merged 7 commits into from
Dec 15, 2023

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg commented Dec 7, 2023

Fixes #4281

Short description of the changes

Await async resources, related to #3460

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added unit tests for the change

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@hectorhdzg hectorhdzg requested a review from a team December 7, 2023 22:28
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #4349 (0d1a1d3) into main (d3c311a) will increase coverage by 0.02%.
The diff coverage is 94.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4349      +/-   ##
==========================================
+ Coverage   92.20%   92.23%   +0.02%     
==========================================
  Files         332      332              
  Lines        9447     9464      +17     
  Branches     2003     2009       +6     
==========================================
+ Hits         8711     8729      +18     
+ Misses        736      735       -1     
Files Coverage Δ
...sdk-logs/src/export/BatchLogRecordProcessorBase.ts 92.85% <93.33%> (-2.02%) ⬇️
...es/sdk-logs/src/export/SimpleLogRecordProcessor.ts 93.33% <94.73%> (+14.38%) ⬆️

... and 1 file with indirect coverage changes

@legendecas legendecas merged commit d828041 into open-telemetry:main Dec 15, 2023
20 checks passed
rdeavila94 pushed a commit to rdeavila94/opentelemetry-js that referenced this pull request Jan 3, 2024
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk-logs] log record processors do not await async resources
4 participants