-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk-logs): await async resources in log processors #4349
Merged
legendecas
merged 7 commits into
open-telemetry:main
from
hectorhdzg:hectorhdzg/asyncres
Dec 15, 2023
Merged
fix(sdk-logs): await async resources in log processors #4349
legendecas
merged 7 commits into
open-telemetry:main
from
hectorhdzg:hectorhdzg/asyncres
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
==========================================
+ Coverage 92.20% 92.23% +0.02%
==========================================
Files 332 332
Lines 9447 9464 +17
Branches 2003 2009 +6
==========================================
+ Hits 8711 8729 +18
+ Misses 736 735 -1
|
legendecas
reviewed
Dec 12, 2023
experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts
Outdated
Show resolved
Hide resolved
experimental/packages/sdk-logs/src/export/SimpleLogRecordProcessor.ts
Outdated
Show resolved
Hide resolved
experimental/packages/sdk-logs/src/export/SimpleLogRecordProcessor.ts
Outdated
Show resolved
Hide resolved
legendecas
approved these changes
Dec 14, 2023
dyladan
approved these changes
Dec 14, 2023
experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts
Outdated
Show resolved
Hide resolved
experimental/packages/sdk-logs/src/export/BatchLogRecordProcessorBase.ts
Outdated
Show resolved
Hide resolved
experimental/packages/sdk-logs/src/export/SimpleLogRecordProcessor.ts
Outdated
Show resolved
Hide resolved
experimental/packages/sdk-logs/src/export/SimpleLogRecordProcessor.ts
Outdated
Show resolved
Hide resolved
legendecas
approved these changes
Dec 15, 2023
rdeavila94
pushed a commit
to rdeavila94/opentelemetry-js
that referenced
this pull request
Jan 3, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4281
Short description of the changes
Await async resources, related to #3460
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: