fix(instrumentation-fetch): compatibility with Map inputs for request headers with fetch #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts for request headers with fetch
rdeavila94
force-pushed
the
map-input-fix
branch
from
31e6b9b to
1c8d8f2
Compare
pichlermarc
changed the title
pichlermarc
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Hi @rdeavila94, thank you for your contribution.
Unfortunately we cannot merge the PR unless the Contributor License Agreement is signed (see here #4348 (comment)) - please ensure that it is signed so that we can proceed with the review process, thanks! 🙂
Co-authored-by: Marc Pichler <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4348 +/- ##
=======================================
Coverage 92.22% 92.23%
=======================================
Files 336 336
Lines 9522 9525 +3
Branches 2018 2020 +2
=======================================
+ Hits 8782 8785 +3
Misses 740 740
|
dyladan
approved these changes
Dec 19, 2023
experimental/packages/opentelemetry-instrumentation-fetch/test/fetch.test.ts
Outdated
Show resolved
Hide resolved
rdeavila94
force-pushed
the
map-input-fix
branch
2 times, most recently
from
d300b82 to
6ebca8e
Compare
pichlermarc
approved these changes
Jan 25, 2024
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
… headers with fetch (open-telemetry#4348) * fix(@opentelemetry-instrumentation-fetch): compatibility with Map inputs for request headers with fetch * Update experimental/CHANGELOG.md Co-authored-by: Marc Pichler <[email protected]> * adding description for ts-ignore * fix(changlog): move entry to unreleased * fix: add lint ignore --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uts for request headers with fetch
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
#4347 (comment)
Short description of the changes
_addHeadersis not handling a type of Map, so it is resorting to extracting the keys as if the headers are an object literal, which it isn't.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: