-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove unnecessary base64 encode+decode from OTLP export #4343
Merged
dyladan
merged 10 commits into
open-telemetry:main
from
seemk:remove-unnecessary-base64-encoding
Dec 19, 2023
Merged
perf: remove unnecessary base64 encode+decode from OTLP export #4343
dyladan
merged 10 commits into
open-telemetry:main
from
seemk:remove-unnecessary-base64-encoding
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4343 +/- ##
==========================================
- Coverage 92.23% 92.22% -0.01%
==========================================
Files 332 333 +1
Lines 9467 9459 -8
Branches 2011 2009 -2
==========================================
- Hits 8732 8724 -8
Misses 735 735
|
dyladan
approved these changes
Dec 13, 2023
dyladan
changed the title
fix: remove unnecessary base64 encode+decode from OTLP export
perf: remove unnecessary base64 encode+decode from OTLP export
Dec 19, 2023
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…telemetry#4343) * fix: remove unnecessary base64 encoding for span contexts * chore: add changelog --------- Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #4338
Short description of the changes
Converting trace and span IDs to base64 is not necessary for protobuf serialization, where the base64 strings would be decoded back to their binary forms when serializing the payload.
hexToBase64
is no longer necessary (except for tests), but since it's exported by@opentelemetry/core
I didn't delete it. Perhaps up for removal in 2.0?How Has This Been Tested?
Modified unit tests and tested http, proto and grpc exporters against collector.
Checklist: