[next] Add support for node 20 #4331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
commented
Nov 29, 2023
Comment on lines
+333
to
+335
| if (request.listenerCount('request') <= 0) { | ||
| response.resume(); | ||
| } |
There was a problem hiding this comment.
If we are the only listener, we have to make sure to read the response data. Otherwise the connection is never closed.
dyladan
commented
Nov 29, 2023
| @@ -22,7 +22,7 @@ export async function sendRequestTwice( | |||
| port: number | |||
| ): Promise<Buffer> { | |||
| return new Promise((resolve, reject) => { | |||
| const request = 'GET /raw HTTP/1.1\n\n'; | |||
| const request = `GET /raw HTTP/1.1\r\nHost: ${host}:${port}\r\n\r\n`; | |||
There was a problem hiding this comment.
According to spec Host header is required. In node 20 this started to be enforced by default. Spec also requires \r\n not \n.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #4331 +/- ##
==========================================
- Coverage 92.24% 92.16% -0.09%
==========================================
Files 332 316 -16
Lines 9437 8536 -901
Branches 1999 1803 -196
==========================================
- Hits 8705 7867 -838
+ Misses 732 669 -63
|
Flarna
approved these changes
Nov 29, 2023
trentm
reviewed
Nov 29, 2023
| @@ -330,6 +330,9 @@ export class HttpInstrumentation extends InstrumentationBase<Http> { | |||
| 'response', | |||
| (response: http.IncomingMessage & { aborted?: boolean }) => { | |||
| this._diag.debug('outgoingRequest on response()'); | |||
| if (request.listenerCount('request') <= 0) { | |||
There was a problem hiding this comment.
Suggested change
| if (request.listenerCount('request') <= 0) { | |
| if (request.listenerCount('response') <= 0) { |
Naive Q: should that eventName be response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of these changes fixes a memory leak. It is implemented for
1.xin #4332. The other is simply an HTTP specification fix which only affects testing.