fix(@opentelemetry/api:test): Major upgrade of webpack to 5.85.0 and use xxhash64 hash function #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes @opentelemetry/api:test failures of the form
```
3) tree-shaking
verify TraceAPI:
Uncaught Error: error:0308010C:digital envelope routines::unsupported
at new Hash (node:internal/crypto/hash:69:19)
at Object.createHash (node:crypto:133:10)
at module.exports (node_modules/webpack/lib/util/createHash.js:135:53)
at NormalModule._initBuildHash (node_modules/webpack/lib/NormalModule.js:417:16)
at handleParseError (node_modules/webpack/lib/NormalModule.js:471:10)
```
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4322 +/- ##
==========================================
+ Coverage 92.31% 92.63% +0.32%
==========================================
Files 330 296 -34
Lines 9424 8300 -1124
Branches 1998 1717 -281
==========================================
- Hits 8700 7689 -1011
+ Misses 724 611 -113 |
|
Clearly, webpack-5.x is more than I can deal with... I defer to someone else who understands webpack/karma/browser runners better than I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes errors when trying to run unit tests on Mac OS with Node v18 and above.
Fixes #4321
Short description of the changes
Upgrade
webpackfrom4.46.0to5.85.0Type of change
How Has This Been Tested?
Ran all tests locally. All tests now pass instead of throwing errors about unsupported openssl functions
Checklist:
Unclear whether this requires a CHANGELOG.md update -- since it a bug fix to unit tests.