Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix npm release preparation scripts, add .npmrc and release script #4275

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

Release preparations scripts are currently broken. #4265
This PR

  • fixes the scripts by making them remove packages npm workspaces instead before bumping the versions.
  • add the release script that maintainers run to publish new versions
  • adds an .npmrc file that

Fixes #4265

Type of change

  • internal

How Has This Been Tested?

  • Manual testing

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #4275 (f8b580b) into main (5ed54c8) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head f8b580b differs from pull request most recent head 1b8281a. Consider uploading reports for the commit 1b8281a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
- Coverage   92.31%   92.31%   -0.01%     
==========================================
  Files         330      330              
  Lines        9424     9421       -3     
  Branches     1998     1996       -2     
==========================================
- Hits         8700     8697       -3     
  Misses        724      724              

see 2 files with indirect coverage changes

package.json Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit 2c7d5c4 into open-telemetry:main Nov 15, 2023
16 checks passed
@pichlermarc pichlermarc deleted the fix/release-scripts branch November 15, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[internal] fix release preparation scripts
4 participants