Lint fixes - api module #4272
Closed
Lint fixes - api module #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
legendecas
reviewed
Nov 29, 2023
| @@ -27,7 +27,7 @@ import { Context } from '../context/types'; | |||
| * usually implemented via library-specific request interceptors, where the | |||
| * client-side injects values and the server-side extracts them. | |||
| */ | |||
| export interface TextMapPropagator<Carrier = any> { | |||
There was a problem hiding this comment.
Changing the default value of a parameter would be a breaking change. I'd suggest leaving this as is.
|
Would you mind signing the CLA so that we can accept your patch? |
|
Thank you for opening this PR. Unfortunately, we need the CLA to be signed before we can continue with the review process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: