-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: track package-lock.json #4238
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1c9205f
chore: track package-lock.json
legendecas de24a33
Pin to old versions for node 14
dyladan b96c3d9
Use version range
dyladan 1dbf56d
Remove unused cached directories
dyladan 6f7706a
Temporarily disable other tests
dyladan 2edd213
Temporarily enable only api test
dyladan 68931bf
Enable only some packages
dyladan 0bb77a0
Test only api packages
dyladan 7aaa168
Test trace exporters
dyladan 375ac6c
Fix line ordering
dyladan 1041126
Test all packages except otlp exporters
dyladan da4ac69
Add trace http exporter
dyladan 6b18e61
Add trace proto exporter
dyladan bc5f011
Test all but grpc exporters
dyladan f9b1dc7
chore: use npm workspaces and degrade lerna to v6
legendecas 5093a10
chore: get rid of lerna bootstrap
legendecas a24e0d5
chore: use npx
legendecas e6b1b8f
chore: allow install scripts to setup buf
legendecas 1c4e7e2
chore: fix w3c-integration-test cache key
legendecas 36833f5
chore: fix cache key
legendecas 6c47b32
chore: disable resource compat test
legendecas 3f168db
chore: fix node_modules assumptions
legendecas 08225f1
chore: fix hoisted karma issue
legendecas 89113f9
chore: fix markdown linter complaints
legendecas e331083
chore: lock @grpc/grpc-js to v1.8.21
legendecas 8d7f865
Break caches
dyladan ba0d37b
chore: remove cache
legendecas a639048
chore: fixup inline commands
legendecas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,31 +33,11 @@ jobs: | |
- run: npm install -g npm@"<10.0.0" | ||
if: ${{ matrix.node_version == '14' || matrix.node_version == '16' }} | ||
|
||
- name: restore lerna | ||
id: cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: | | ||
node_modules | ||
package-lock.json | ||
packages/*/node_modules | ||
packages/*/package-lock.json | ||
experimental/packages/*/node_modules | ||
experimental/packages/*/package-lock.json | ||
key: node-tests-${{ runner.os }}-${{ matrix.node_version }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 | ||
|
||
# temporary fix for https://github.com/nrwl/nx/issues/19022 | ||
- run: npm install --save-dev [email protected] @nx/[email protected] | ||
if: ${{ matrix.node_version == '14' }} | ||
|
||
- name: Bootstrap | ||
run: | | ||
npm install --ignore-scripts | ||
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests | ||
run: npm ci | ||
|
||
- name: Build 🔧 | ||
run: | | ||
npm run compile | ||
run: npm run compile | ||
|
||
- name: Unit tests | ||
run: | | ||
|
@@ -83,23 +63,8 @@ jobs: | |
|
||
- run: npm install -g npm@latest | ||
|
||
- name: restore lerna | ||
id: cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: | | ||
node_modules | ||
package-lock.json | ||
packages/*/node_modules | ||
packages/*/package-lock.json | ||
experimental/packages/*/node_modules | ||
experimental/packages/*/package-lock.json | ||
key: node-windows-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }} | ||
|
||
- name: Bootstrap | ||
run: | | ||
npm install --ignore-scripts | ||
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests | ||
run: npm ci | ||
|
||
- name: Build 🔧 | ||
run: | | ||
|
@@ -122,27 +87,11 @@ jobs: | |
with: | ||
node-version: 16 | ||
|
||
- name: restore lerna | ||
id: cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: | | ||
node_modules | ||
package-lock.json | ||
packages/*/node_modules | ||
packages/*/package-lock.json | ||
experimental/packages/*/node_modules | ||
experimental/packages/*/package-lock.json | ||
key: browser-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 | ||
|
||
- name: Bootstrap | ||
run: | | ||
npm install --ignore-scripts | ||
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' --ignore @opentelemetry/selenium-tests | ||
run: npm ci | ||
|
||
- name: Build 🔧 | ||
run: | | ||
npm run compile | ||
run: npm run compile | ||
|
||
- name: Unit tests | ||
run: npm run test:browser | ||
|
@@ -159,27 +108,11 @@ jobs: | |
with: | ||
node-version: 16 | ||
|
||
- name: restore lerna | ||
id: cache | ||
uses: actions/cache@v3 | ||
with: | ||
path: | | ||
node_modules | ||
package-lock.json | ||
packages/*/node_modules | ||
packages/*/package-lock.json | ||
experimental/packages/*/node_modules | ||
experimental/packages/*/package-lock.json | ||
key: webworker-tests-${{ runner.os }}-${{ hashFiles('package.json', 'packages/*/package.json', 'experimental/packages/*/package.json') }}-04292022 | ||
|
||
- name: Bootstrap | ||
run: | | ||
npm install --ignore-scripts | ||
npx lerna bootstrap --no-ci --hoist --nohoist='zone.js' | ||
run: npm ci | ||
|
||
- name: Build 🔧 | ||
run: | | ||
npm run compile | ||
run: npm run compile | ||
|
||
- name: Unit tests | ||
run: npm run test:webworker | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,6 @@ typings/ | |
|
||
# lock files | ||
yarn.lock | ||
package-lock.json | ||
|
||
# docs files | ||
docs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This
npm install semver
installs all dependencies anyway (npm issue: npm/cli#3023). This could consider just runningnpm ci
OR also installing semver globally (untested):npm install -g semver
. The latter, if it works, would avoid installing ~800MB of deps.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4242