Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump deploy docs workflow to node 18 #4199

Merged

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

The "Deploy API Documentation" workflow is not working right now as we updated dependencies to a pont where they are not compatible with Node.js 14 anymore.

This PR bumps Node.js to 18 for this workflow.

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file internal labels Oct 10, 2023
@pichlermarc pichlermarc requested a review from a team October 10, 2023 14:42
@pichlermarc pichlermarc changed the title fix: bump deploy docs to node 18 fix: bump deploy docs workflow to node 18 Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4199 (3ac1de3) into main (f8e187b) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 3ac1de3 differs from pull request most recent head 4f94a66. Consider uploading reports for the commit 4f94a66 to get more accurate results

@@            Coverage Diff             @@
##             main    #4199      +/-   ##
==========================================
- Coverage   92.24%   92.23%   -0.02%     
==========================================
  Files         331      331              
  Lines        9479     9479              
  Branches     1999     1999              
==========================================
- Hits         8744     8743       -1     
- Misses        735      736       +1     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc merged commit 7f52f70 into open-telemetry:main Oct 18, 2023
9 checks passed
@pichlermarc pichlermarc deleted the fix/deploy-docs branch October 18, 2023 11:58
seemk pushed a commit to seemk/opentelemetry-js that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants