Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release API 1.6.0/SDK 1.17.0/Experimental 0.43.0 #4138

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Sep 11, 2023

Release PR for #4137 (needs rebase after the PR merges). We peer-depend on API <1.6.0 in the SDK packages, therefore we need to release everything.

API 1.6.0

🐛 (Bug Fix)

  • Revert "feat(api): add attributes argument to recordException API #4071"
    • This feature was an unintentional breaking change introduced with 1.5.0

SDK 1.17.0

🐛 (Bug Fix)

  • Revert "feat(api): add attributes argument to recordException API #4071"
    • This feature was an unintentional breaking change introduced with API 1.5.0
    • This PR updates all SDK packages to allow API 1.6.0, where this change has been reverted.

Experimental 0.43.0

🐛 (Bug Fix)

  • Revert "feat(api): add attributes argument to recordException API #4071"
    • This feature was an unintentional breaking change introduced with API 1.5.0
    • This PR updates all experimental packages to allow API 1.6.0, where this change has been reverted.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4138 (a6b4375) into main (27897d6) will increase coverage by 2.55%.
The diff coverage is n/a.

❗ Current head a6b4375 differs from pull request most recent head 5be7de4. Consider uploading reports for the commit 5be7de4 to get more accurate results

@@            Coverage Diff             @@
##             main    #4138      +/-   ##
==========================================
+ Coverage   89.68%   92.23%   +2.55%     
==========================================
  Files         140      326     +186     
  Lines        3014     9299    +6285     
  Branches      653     1971    +1318     
==========================================
+ Hits         2703     8577    +5874     
- Misses        311      722     +411     

@pichlermarc pichlermarc marked this pull request as ready for review September 11, 2023 15:39
@pichlermarc pichlermarc requested review from a team September 11, 2023 15:39
@dyladan
Copy link
Member

dyladan commented Sep 12, 2023

Should this be API 1.5.1 or 1.6.0? Anyone depending on ^1.5.0 could see a breaking change by this "fix." Not sure how semver handles making breaking changes when the bug is itself just a semver violation? This would simply be introducing another breaking change. the argument could be made that 1.5.0 should instead be deprecated or something? I'm really unsure.

I'm also unsure that I agree with reverting this change. It is not breaking for end users, only implementers. This is why our SDKs specify a maxiumum API version in the peer dependencies (example: https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-base/package.json#L93).

@dyladan
Copy link
Member

dyladan commented Sep 12, 2023

/cc @ksstoneware for visibility on my above comment

@dyladan
Copy link
Member

dyladan commented Sep 12, 2023

I'm also unsure that I agree with reverting this change. It is not breaking for end users, only implementers. This is why our SDKs specify a maxiumum API version in the peer dependencies (example: https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-base/package.json#L93).

After thinking more about it. Let's go ahead and revert this for now. It's clear that the third party SDK implementers (afaik dd is the only one) didn't have the same expectations we did. In the SIG meeting we'll discuss how we want to deal with changes like this moving forward.

@dyladan
Copy link
Member

dyladan commented Sep 12, 2023

@pichlermarc pichlermarc merged commit faf939c into open-telemetry:main Sep 12, 2023
@pichlermarc pichlermarc deleted the release/api-1.6.0 branch September 12, 2023 11:47
@vinicius73
Copy link

Hi @pichlermarc cold you release 1.6.0 at npm?
At now we only have 1.5.0

@BrettHoutz
Copy link

It has been released now.

@pichlermarc
Copy link
Member Author

@vinicius73 yes - the release process takes some time but it should be up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants