-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release API 1.6.0/SDK 1.17.0/Experimental 0.43.0 #4138
chore: release API 1.6.0/SDK 1.17.0/Experimental 0.43.0 #4138
Conversation
…en-telemetry#4071)" This reverts commit cd4998a.
Codecov Report
@@ Coverage Diff @@
## main #4138 +/- ##
==========================================
+ Coverage 89.68% 92.23% +2.55%
==========================================
Files 140 326 +186
Lines 3014 9299 +6285
Branches 653 1971 +1318
==========================================
+ Hits 2703 8577 +5874
- Misses 311 722 +411 |
Should this be API 1.5.1 or 1.6.0? Anyone depending on I'm also unsure that I agree with reverting this change. It is not breaking for end users, only implementers. This is why our SDKs specify a maxiumum API version in the peer dependencies (example: https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-sdk-trace-base/package.json#L93). |
/cc @ksstoneware for visibility on my above comment |
After thinking more about it. Let's go ahead and revert this for now. It's clear that the third party SDK implementers (afaik dd is the only one) didn't have the same expectations we did. In the SIG meeting we'll discuss how we want to deal with changes like this moving forward. |
This PR follows the official semver guidelines |
Hi @pichlermarc cold you release 1.6.0 at npm? |
It has been released now. |
@vinicius73 yes - the release process takes some time but it should be up now. |
Release PR for #4137
(needs rebase after the PR merges).We peer-depend on API <1.6.0 in the SDK packages, therefore we need to release everything.API 1.6.0
🐛 (Bug Fix)
SDK 1.17.0
🐛 (Bug Fix)
Experimental 0.43.0
🐛 (Bug Fix)