Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk-node): move @opentelemetry/exporter-jaeger to dev dependencies #4049

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix(sdk-node): move @opentelemetry/exporter-jaeger to dev dependencies #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae4acdc
move @opentelemetry/exporter-jaeger to dev dependencies
Vadman97 Aug 9, 2023
4c1dc82
fixup! move @opentelemetry/exporter-jaeger to dev dependencies
Vadman97 Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ All notable changes to experimental packages in this project will be documented
### :bug: (Bug Fix)

* fix(exporter-logs-otlp-http): add @opentelemetry/api-logs as dependency
* fix(sdk-node): remove explicit dependency on @opentelemetry/exporter-jaeger.

## 0.41.2

Expand Down
1 change: 1 addition & 0 deletions experimental/packages/opentelemetry-sdk-node/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Before any other module in your application is loaded, you must initialize the S
If you fail to initialize the SDK or initialize it too late, no-op implementations will be provided to any library which acquires a tracer or meter from the API.

This example uses Jaeger and Prometheus, but exporters exist for [other tracing backends][other-tracing-backends].
As shown in the installation instructions, exporters passed to the SDK must be installed alongside `@opentelemetry/sdk-node`.

```javascript
const opentelemetry = require("@opentelemetry/sdk-node");
Expand Down
1 change: 1 addition & 0 deletions experimental/packages/opentelemetry-sdk-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"devDependencies": {
"@opentelemetry/api": "1.6.0",
"@opentelemetry/context-async-hooks": "1.17.0",
"@opentelemetry/exporter-jaeger": "1.17.0",
"@types/mocha": "10.0.1",
"@types/node": "18.6.5",
"@types/semver": "7.5.1",
Expand Down
Loading