Merge branch 'main' into dropped-attributes-count

open-telemetry · Nov 22, 2023 · 1ca1786 · 1ca1786
2 parents 55d5cad + b3a539d
commit 1ca1786
Show file tree

Hide file tree

Showing 56 changed files with 568 additions and 2,045 deletions.
diff --git a/.npmrc b/.npmrc
@@ -0,0 +1,2 @@
+//registry.npmjs.org/:_authToken=${NPM_TOKEN}
+lockfile-version=2
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,6 +20,9 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 
 ### :bug: (Bug Fix)
 
+* fix(sdk-trace-web): only access location if it is defined [#4063](https://github.com/open-telemetry/opentelemetry-js/pull/4063)
+* fix(sdk-trace-base): processor onStart called with a span having empty attributes
+
 ## 1.18.1
 
 ### :bug: (Bug Fix)

diff --git a/README.md b/README.md
@@ -210,6 +210,7 @@ We have a weekly SIG meeting! See the [community page](https://github.com/open-t
 - [Neville Wylie](https://github.com/MSNev), Microsoft
 - [Purvi Kanal](https://github.com/pkanal), Honeycomb
 - [Svetlana Brennan](https://github.com/svetlanabrennan), New Relic
+- [Trent Mick](https://github.com/trentm), Elastic
 
 *Find more about the approver role in [community repository](https://github.com/open-telemetry/community/blob/main/community-membership.md#approver).*
 

diff --git a/api/package.json b/api/package.json
@@ -66,10 +66,10 @@
     "access": "public"
   },
   "devDependencies": {
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
-    "@types/webpack": "4.41.35",
+    "@types/webpack": "4.41.36",
     "@types/webpack-env": "1.16.3",
     "babel-plugin-istanbul": "6.1.1",
     "codecov": "3.8.3",

diff --git a/experimental/CHANGELOG.md b/experimental/CHANGELOG.md
@@ -13,6 +13,8 @@ All notable changes to experimental packages in this project will be documented
 ### :bug: (Bug Fix)
 
 * fix(sdk-logs): avoid map attribute set when count limit exceeded
+* fix(instrumentation-fetch): only access navigator if it is defined [#4063](https://github.com/open-telemetry/opentelemetry-js/pull/4063)
+  * allows for experimental usage of this instrumentation with non-browser runtimes
 
 ### :books: (Refine Doc)
 

diff --git a/experimental/packages/api-events/package.json b/experimental/packages/api-events/package.json
@@ -64,7 +64,7 @@
     "@opentelemetry/api": "^1.0.0"
   },
   "devDependencies": {
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/webpack-env": "1.16.3",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/api-logs/package.json b/experimental/packages/api-logs/package.json
@@ -64,7 +64,7 @@
     "@opentelemetry/api": "^1.0.0"
   },
   "devDependencies": {
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/webpack-env": "1.16.3",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/exporter-logs-otlp-grpc/package.json b/experimental/packages/exporter-logs-otlp-grpc/package.json
@@ -48,13 +48,13 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@grpc/proto-loader": "^0.7.10",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/api-logs": "0.45.1",
     "@opentelemetry/otlp-exporter-base": "0.45.1",
     "@opentelemetry/resources": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/exporter-logs-otlp-http/package.json b/experimental/packages/exporter-logs-otlp-http/package.json
@@ -71,10 +71,10 @@
   ],
   "sideEffects": false,
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/resources": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",

diff --git a/experimental/packages/exporter-logs-otlp-proto/package.json b/experimental/packages/exporter-logs-otlp-proto/package.json
@@ -63,9 +63,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/exporter-trace-otlp-grpc/package.json b/experimental/packages/exporter-trace-otlp-grpc/package.json
@@ -47,11 +47,11 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@grpc/proto-loader": "^0.7.10",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/otlp-exporter-base": "0.45.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/exporter-trace-otlp-http/package.json b/experimental/packages/exporter-trace-otlp-http/package.json
@@ -63,9 +63,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",

diff --git a/experimental/packages/exporter-trace-otlp-proto/package.json b/experimental/packages/exporter-trace-otlp-proto/package.json
@@ -62,9 +62,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/opentelemetry-browser-detector/package.json b/experimental/packages/opentelemetry-browser-detector/package.json
@@ -53,9 +53,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/package.json
@@ -47,10 +47,10 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@grpc/proto-loader": "^0.7.10",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-http/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-http/package.json
@@ -63,9 +63,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",

diff --git a/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/package.json b/experimental/packages/opentelemetry-exporter-metrics-otlp-proto/package.json
@@ -55,9 +55,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/opentelemetry-exporter-prometheus/package.json b/experimental/packages/opentelemetry-exporter-prometheus/package.json
@@ -45,7 +45,7 @@
   "devDependencies": {
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/semantic-conventions": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/package.json b/experimental/packages/opentelemetry-instrumentation-fetch/package.json
@@ -54,12 +54,12 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/context-zone": "1.18.1",
     "@opentelemetry/propagator-b3": "1.18.1",
     "@opentelemetry/sdk-trace-base": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",

diff --git a/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts b/experimental/packages/opentelemetry-instrumentation-fetch/src/fetch.ts
@@ -132,7 +132,12 @@ export class FetchInstrumentation extends InstrumentationBase<
       SemanticAttributes.HTTP_SCHEME,
       parsedUrl.protocol.replace(':', '')
     );
-    span.setAttribute(SemanticAttributes.HTTP_USER_AGENT, navigator.userAgent);
+    if (typeof navigator !== 'undefined') {
+      span.setAttribute(
+        SemanticAttributes.HTTP_USER_AGENT,
+        navigator.userAgent
+      );
+    }
   }
 
   /**

diff --git a/experimental/packages/opentelemetry-instrumentation-grpc/package.json b/experimental/packages/opentelemetry-instrumentation-grpc/package.json
@@ -57,9 +57,9 @@
     "@protobuf-ts/grpc-transport": "2.9.1",
     "@protobuf-ts/runtime": "2.9.1",
     "@protobuf-ts/runtime-rpc": "2.9.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
-    "@types/semver": "7.5.4",
+    "@types/semver": "7.5.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",
     "cross-var": "1.1.0",

diff --git a/experimental/packages/opentelemetry-instrumentation-http/package.json b/experimental/packages/opentelemetry-instrumentation-http/package.json
@@ -50,12 +50,12 @@
     "@opentelemetry/sdk-metrics": "1.18.1",
     "@opentelemetry/sdk-trace-base": "1.18.1",
     "@opentelemetry/sdk-trace-node": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
-    "@types/request-promise-native": "1.0.20",
-    "@types/semver": "7.5.4",
+    "@types/request-promise-native": "1.0.21",
+    "@types/semver": "7.5.5",
     "@types/sinon": "10.0.20",
-    "@types/superagent": "4.1.20",
+    "@types/superagent": "4.1.21",
     "axios": "1.5.1",
     "codecov": "3.8.3",
     "cross-var": "1.1.0",

diff --git a/experimental/packages/opentelemetry-instrumentation-xml-http-request/package.json b/experimental/packages/opentelemetry-instrumentation-xml-http-request/package.json
@@ -54,12 +54,12 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/context-zone": "1.18.1",
     "@opentelemetry/propagator-b3": "1.18.1",
     "@opentelemetry/sdk-trace-base": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",

diff --git a/experimental/packages/opentelemetry-instrumentation/package.json b/experimental/packages/opentelemetry-instrumentation/package.json
@@ -81,12 +81,12 @@
     "@opentelemetry/api": "^1.3.0"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/sdk-metrics": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
-    "@types/semver": "7.5.4",
+    "@types/semver": "7.5.5",
     "@types/sinon": "10.0.20",
     "@types/webpack-env": "1.16.3",
     "babel-loader": "8.3.0",

diff --git a/experimental/packages/opentelemetry-sdk-node/package.json b/experimental/packages/opentelemetry-sdk-node/package.json
@@ -65,9 +65,9 @@
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/context-async-hooks": "1.18.1",
     "@opentelemetry/exporter-jaeger": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
-    "@types/semver": "7.5.4",
+    "@types/semver": "7.5.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",
     "cross-var": "1.1.0",

diff --git a/experimental/packages/otlp-exporter-base/package.json b/experimental/packages/otlp-exporter-base/package.json
@@ -64,9 +64,9 @@
     "@opentelemetry/core": "1.18.1"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/otlp-grpc-exporter-base/package.json b/experimental/packages/otlp-grpc-exporter-base/package.json
@@ -48,12 +48,12 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/otlp-transformer": "0.45.1",
     "@opentelemetry/resources": "1.18.1",
     "@opentelemetry/sdk-trace-base": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/otlp-proto-exporter-base/package.json b/experimental/packages/otlp-proto-exporter-base/package.json
@@ -59,9 +59,9 @@
     "access": "public"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",

diff --git a/experimental/packages/otlp-transformer/package.json b/experimental/packages/otlp-transformer/package.json
@@ -59,7 +59,7 @@
   },
   "devDependencies": {
     "@opentelemetry/api": "1.7.0",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/webpack-env": "1.16.3",
     "babel-plugin-istanbul": "6.1.1",
     "codecov": "3.8.3",

diff --git a/experimental/packages/sdk-logs/package.json b/experimental/packages/sdk-logs/package.json
@@ -72,10 +72,10 @@
     "@opentelemetry/api-logs": ">=0.39.1"
   },
   "devDependencies": {
-    "@babel/core": "7.22.20",
+    "@babel/core": "7.23.3",
     "@opentelemetry/api": ">=1.4.0 <1.8.0",
     "@opentelemetry/api-logs": "0.45.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "babel-plugin-istanbul": "6.1.1",

diff --git a/experimental/packages/shim-opencensus/package.json b/experimental/packages/shim-opencensus/package.json
@@ -52,7 +52,7 @@
     "@opentelemetry/api": "1.7.0",
     "@opentelemetry/context-async-hooks": "1.18.1",
     "@opentelemetry/sdk-trace-base": "1.18.1",
-    "@types/mocha": "10.0.3",
+    "@types/mocha": "10.0.4",
     "@types/node": "18.6.5",
     "@types/sinon": "10.0.20",
     "codecov": "3.8.3",
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		//registry.npmjs.org/:_authToken=${NPM_TOKEN}
		lockfile-version=2