Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(propagator-aws-xray): correctly propagate over grpc #2604

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(propagator-aws-xray): correctly propagate over grpc #2604

wants to merge 2 commits into from

Conversation

dweitzman-codaio
Copy link

Similar to open-telemetry/opentelemetry-js#2285 for the b3 propagator

Which problem is this PR solving?

Fixes open-telemetry/opentelemetry-js#4830

Short description of the changes

@dweitzman-codaio dweitzman-codaio requested a review from a team as a code owner December 13, 2024 19:59
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. pkg:propagator-aws-xray labels Dec 13, 2024
@github-actions github-actions bot requested a review from jj22ee December 13, 2024 19:59
@dweitzman-codaio dweitzman-codaio changed the title Fix grpc propagation with XRay propagator fix(propagator-aws-xray): correctly propagate over grpc Dec 13, 2024
@dweitzman-codaio
Copy link
Author

cc @dyladan since open-telemetry/opentelemetry-js#4830 is currently assigned to you

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@pichlermarc pichlermarc removed pkg-status:unmaintained This package is unmaintained. Only bugfixes may be acceped until a new owner has been found. pkg-status:unmaintained:autoclose-scheduled labels Dec 16, 2024
@pichlermarc
Copy link
Member

Note: "unmaintained" label was applied incorrectly, @jj22ee is the owner.
I opened #2606 to address this.

@jj22ee
Copy link
Contributor

jj22ee commented Dec 17, 2024 •
edited
Loading

LGTM. Can you add a test case for this fix, similar to the B3 one?

@dweitzman-codaio
Copy link
Author

LGTM. Can you add a test case for this fix, similar to the B3 one?

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jj22ee jj22ee Awaiting requested review from jj22ee

At least 1 approving review is required to merge this pull request.

Assignees

@jj22ee jj22ee

Labels
pkg:propagator-aws-xray
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

propagator-aws-xray broken with GRPC?
3 participants
@dweitzman-codaio @pichlermarc @jj22ee