fix(detector-aws): update aws lambda detector #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garysassano
changed the title
jj22ee
reviewed
Dec 10, 2024
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Outdated
Show resolved
Hide resolved
| 'aws.log.group.names': [logGroupName], | ||
| 'cloud.provider': 'aws', | ||
| 'cloud.platform': 'aws_lambda', | ||
| 'cloud.region': awsRegion, |
There was a problem hiding this comment.
For attribute values that can possibly be undefined (even if not expected to be so), I think it would be safer to keep the if checks to only add such attributes if defined.
There was a problem hiding this comment.
In this context, it's unnecessary to check for undefined runtime environment variables. Since you're already ensuring the code runs within a Lambda environment, these variables are guaranteed to be present. Adding extra checks for them would undermine the purpose of AWS's standardization across Lambda runtimes, as detailed in the docs.
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Show resolved
Hide resolved
detectors/node/opentelemetry-resource-detector-aws/src/detectors/AwsLambdaDetectorSync.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Removing deprecated imports
Adding extra attributes:
aws.log.group.names,faas.instance,faas.max_memoryShort description of the changes
See above.