Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib-test-utils): copy soon-to-be-removed types from @opentelemetry/otlp-transformer #2573

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Dec 2, 2024

Which problem is this PR solving?

We're about to remove the intermediate OTLP types from @opentelemetry/otlp-transformer as we now have an interface that allows us to serialize directly to OTLP(protobuf) or OTLP(json).

Since they were used for testing here, we need to duplicate the relevant ones so that we're not blocked on the next core update.

Closes #2565

Short description of the changes

  • changes export * to explicit exports to avoid exporting anything we don't intend
  • copies types from @opentelemetry/otlp-transformer
  • moves the OtlpSpanKind enum from test-fixtures.ts to otlp-types.ts

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (e3c9150) to head (73fe3f7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   90.80%   90.75%   -0.05%     
==========================================
  Files         169      169              
  Lines        8026     8026              
  Branches     1635     1635              
==========================================
- Hits         7288     7284       -4     
- Misses        738      742       +4     

see 1 file with indirect coverage changes

@pichlermarc
Copy link
Member Author

Note: TAV tests will fail here due to #2572 - it's unrelated to this PR.

@pichlermarc pichlermarc marked this pull request as ready for review December 2, 2024 15:57
@pichlermarc pichlermarc requested a review from a team as a code owner December 2, 2024 15:57
@pichlermarc pichlermarc merged commit 23a345d into open-telemetry:main Dec 5, 2024
11 checks passed
@dyladan dyladan mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment