-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contrib-test-utils): copy soon-to-be-removed types from @opentelemetry/otlp-transformer #2573
Merged
pichlermarc
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:refactor/test-utils-transformer-types
Dec 5, 2024
Merged
feat(contrib-test-utils): copy soon-to-be-removed types from @opentelemetry/otlp-transformer #2573
pichlermarc
merged 7 commits into
open-telemetry:main
from
dynatrace-oss-contrib:refactor/test-utils-transformer-types
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emetry/otlp-transformer
github-actions
bot
added
pkg:instrumentation-ioredis
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg:resource-detector-alibaba-cloud
pkg:resource-detector-aws
pkg:resource-detector-gcp
pkg:resource-detector-instana
pkg:propagation-utils
pkg:instrumentation-amqplib
pkg:instrumentation-lru-memoizer
pkg:instrumentation-mongoose
pkg:instrumentation-tedious
pkg:instrumentation-aws-sdk
pkg:instrumentation-cassandra-driver
pkg:instrumentation-fastify
pkg:instrumentation-koa
pkg:instrumentation-memcached
pkg:instrumentation-mongodb
pkg:instrumentation-pg
pkg:instrumentation-pino
pkg:instrumentation-redis-4
pkg:instrumentation-redis
labels
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
- Coverage 90.80% 90.75% -0.05%
==========================================
Files 169 169
Lines 8026 8026
Branches 1635 1635
==========================================
- Hits 7288 7284 -4
- Misses 738 742 +4 |
Note: TAV tests will fail here due to #2572 - it's unrelated to this PR. |
maryliag
approved these changes
Dec 2, 2024
JacksonWeber
reviewed
Dec 2, 2024
Co-authored-by: Jackson Weber <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:instrumentation-amqplib
pkg:instrumentation-aws-sdk
pkg:instrumentation-cassandra-driver
pkg:instrumentation-fastify
pkg:instrumentation-ioredis
pkg:instrumentation-koa
pkg:instrumentation-lru-memoizer
pkg:instrumentation-memcached
pkg:instrumentation-mongodb
pkg:instrumentation-mongoose
pkg:instrumentation-mysql
pkg:instrumentation-mysql2
pkg:instrumentation-pg
pkg:instrumentation-pino
pkg:instrumentation-redis
pkg:instrumentation-redis-4
pkg:instrumentation-socket.io
pkg:instrumentation-tedious
pkg:propagation-utils
pkg:resource-detector-alibaba-cloud
pkg:resource-detector-aws
pkg:resource-detector-azure
pkg:resource-detector-container
pkg:resource-detector-gcp
pkg:resource-detector-instana
pkg:sampler-aws-xray
pkg:test-utils
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We're about to remove the intermediate OTLP types from
@opentelemetry/otlp-transformer
as we now have an interface that allows us to serialize directly to OTLP(protobuf) or OTLP(json).Since they were used for testing here, we need to duplicate the relevant ones so that we're not blocked on the next core update.
Closes #2565
Short description of the changes
export *
to explicit exports to avoid exporting anything we don't intend@opentelemetry/otlp-transformer
OtlpSpanKind
enum fromtest-fixtures.ts
tootlp-types.ts