-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): lock file maintenance #2225
feat(deps): lock file maintenance #2225
Conversation
ec08f63
to
9d253d0
Compare
b75f7ae
to
f9b8733
Compare
70575b9
to
52ad4a5
Compare
This is the same issue that Martin hit in #2299 recently, explained here: tl;dr: I'm pretty sure (I haven't checked yet because yah 23k line package-lock.json diff!) the update includes an update to |
Confirmed, the diff includes: "node_modules/@types/scheduler": {
- "version": "0.16.8",
- "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz",
- "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==",
+ "version": "0.23.0",
+ "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.23.0.tgz",
+ "integrity": "sha512-YIoDCTH3Af6XM5VuwGG/QL/CJqga1Zm3NkU3HZ4ZHK2fRMPYP1VczsTUqtsf43PH/iJNVlPHAo2oWX7BSdB2Hw==",
"dev": true
}, but
opentelemetry-js-contrib/plugins/web/opentelemetry-plugin-react-load/package.json Line 58 in 9dc55da
@pichlermarc Would we prefer that is done in a separate PR? Or update (some of) those devDependencies to caret ranges? |
6d55919
to
2736d62
Compare
532b1a3
to
040c9e7
Compare
040c9e7
to
fca2e3f
Compare
fca2e3f
to
38193f3
Compare
38193f3
to
26a1d52
Compare
a74d973
to
501619c
Compare
9bd85a7
to
96b7a85
Compare
74c0cbf
to
67edc22
Compare
An update of that pinned version was done in #2006. |
But now there are different test failures. Sigh. I'm NOT digging into this for now. |
67edc22
to
c047014
Compare
c047014
to
88f04bf
Compare
d05acd2
to
7fd12ae
Compare
@trentm - I think I finally figured out what was wrong with this PR (sorry for not responding to this before, I just dreaded the diff and every time I looked into it I just could not make sense of it) - I opened #2594 based on this one here. The changes from #2571 were one part of the puzzle - some types were leaking to the public API and that did not work with newer zone.js versions. Then @types/node in the cucumber instrumentation which ended up resolving to @types/node@22 - these were not compatible with some other package in there, so I pinned them to 18.18.14 (like the other packages). And then finally there was the nestjs instrumentation that had a missing package that was breaking tests - installing it made them pass. Now waiting for TAV to pass in #2594 - fingers crossed 🙂 (a side note: for OTel JS core, I think a monorepo + typescript makes sense - but here for Contrib I feel like it gets in the way more often than not and slows us down significantly 😞) |
7fd12ae
to
3c74d77
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
+ Coverage 90.75% 90.91% +0.16%
==========================================
Files 169 169
Lines 8026 8149 +123
Branches 1635 1671 +36
==========================================
+ Hits 7284 7409 +125
+ Misses 742 740 -2 |
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.