Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): lock file maintenance #2225

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 20, 2024

This PR contains the following updates:

Update Change
lockFileMaintenance All locks refreshed

🔧 This Pull Request updates lock files to use the latest dependency versions.


Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team May 20, 2024 00:23
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label May 20, 2024
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from ec08f63 to 9d253d0 Compare May 24, 2024 23:22
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from b75f7ae to f9b8733 Compare June 11, 2024 13:12
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from 70575b9 to 52ad4a5 Compare July 3, 2024 17:02
@trentm
Copy link
Contributor

trentm commented Jul 4, 2024

npm run compile fails with:

 ../../node_modules/@types/react/index.d.ts:36:53 - error TS7016: Could not find a declaration file for module 'scheduler/tracing'. '/home/runner/work/opentelemetry-js-contrib/opentelemetry-js-contrib/node_modules/scheduler/tracing.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/scheduler` if it exists or add a new declaration (.d.ts) file containing `declare module 'scheduler/tracing';`

36 import { Interaction as SchedulerInteraction } from "scheduler/tracing";
                                                       ~~~~~~~~~~~~~~~~~~~

This is the same issue that Martin hit in #2299 recently, explained here:
#2299 (comment)

tl;dr: I'm pretty sure (I haven't checked yet because yah 23k line package-lock.json diff!) the update includes an update to @types/scheduler (a minor update, but it is in 0.x range) that breaks the @types/react that uses it. I'm guessing that @types/react was not updated. The latest @types/react includes a fix to its dependency range on @types/scheduler that should fix the issue.

@trentm
Copy link
Contributor

trentm commented Jul 4, 2024

tl;dr: I'm pretty sure (I haven't checked yet because yah 23k line package-lock.json diff!) the update includes ...

Confirmed, the diff includes:

     "node_modules/@types/scheduler": {
-      "version": "0.16.8",
-      "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.16.8.tgz",
-      "integrity": "sha512-WZLiwShhwLRmeV6zH+GkbOFT6Z6VklCItrDioxUnv+u4Ll+8vKeFySoFyK/0ctcRpOmwAicELfmys1sDc/Rw+A==",
+      "version": "0.23.0",
+      "resolved": "https://registry.npmjs.org/@types/scheduler/-/scheduler-0.23.0.tgz",
+      "integrity": "sha512-YIoDCTH3Af6XM5VuwGG/QL/CJqga1Zm3NkU3HZ4ZHK2fRMPYP1VczsTUqtsf43PH/iJNVlPHAo2oWX7BSdB2Hw==",
       "dev": true
     },

but @types/react is still at the version that doesn't have the fix for this:

% git branch --list
* renovate/lock-file-maintenance
  main

% npm ls --package-lock-only @types/scheduler
[email protected] /Users/trentm/tm/opentelemetry-js-contrib11
└─┬ @opentelemetry/[email protected] -> ./plugins/web/opentelemetry-plugin-react-load
  └─┬ @types/[email protected]
    └── @types/[email protected]

@types/[email protected] has a fix. Can we tell renovate to update that dep as well?
Oh, we'd need to update the pinned version at

@pichlermarc Would we prefer that is done in a separate PR? Or update (some of) those devDependencies to caret ranges?

@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 6d55919 to 2736d62 Compare July 29, 2024 14:35
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from 532b1a3 to 040c9e7 Compare August 20, 2024 20:54
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from 040c9e7 to fca2e3f Compare September 4, 2024 15:13
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from fca2e3f to 38193f3 Compare September 26, 2024 09:47
@renovate-bot renovate-bot requested a review from a team as a code owner September 26, 2024 09:47
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from 38193f3 to 26a1d52 Compare October 8, 2024 10:38
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from a74d973 to 501619c Compare October 21, 2024 16:03
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 2 times, most recently from 9bd85a7 to 96b7a85 Compare October 24, 2024 14:07
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 5 times, most recently from 74c0cbf to 67edc22 Compare November 5, 2024 19:51
@trentm
Copy link
Contributor

trentm commented Nov 7, 2024

@types/[email protected] has a fix. Can we tell renovate to update that dep as well?
Oh, we'd need to update the pinned version at

An update of that pinned version was done in #2006.

@trentm
Copy link
Contributor

trentm commented Nov 7, 2024

But now there are different test failures. Sigh. I'm NOT digging into this for now.

@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from 67edc22 to c047014 Compare November 8, 2024 12:05
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from c047014 to 88f04bf Compare November 25, 2024 18:50
@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch 3 times, most recently from d05acd2 to 7fd12ae Compare December 6, 2024 18:07
@pichlermarc
Copy link
Member

@trentm - I think I finally figured out what was wrong with this PR (sorry for not responding to this before, I just dreaded the diff and every time I looked into it I just could not make sense of it) - I opened #2594 based on this one here.

The changes from #2571 were one part of the puzzle - some types were leaking to the public API and that did not work with newer zone.js versions.

Then @types/node in the cucumber instrumentation which ended up resolving to @types/node@22 - these were not compatible with some other package in there, so I pinned them to 18.18.14 (like the other packages).

And then finally there was the nestjs instrumentation that had a missing package that was breaking tests - installing it made them pass.

Now waiting for TAV to pass in #2594 - fingers crossed 🙂

(a side note: for OTel JS core, I think a monorepo + typescript makes sense - but here for Contrib I feel like it gets in the way more often than not and slows us down significantly 😞)

@renovate-bot renovate-bot force-pushed the renovate/lock-file-maintenance branch from 7fd12ae to 3c74d77 Compare December 7, 2024 01:31
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (30d668e) to head (3c74d77).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2225      +/-   ##
==========================================
+ Coverage   90.75%   90.91%   +0.16%     
==========================================
  Files         169      169              
  Lines        8026     8149     +123     
  Branches     1635     1671      +36     
==========================================
+ Hits         7284     7409     +125     
+ Misses        742      740       -2     

see 1 file with indirect coverage changes

@pichlermarc pichlermarc merged commit 6158af0 into open-telemetry:main Dec 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants