Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only publish after releases are created #2160

Merged

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Add conditional checks to steps that require a release to be created first.

According to release-please-action Outputs section releases_created is true if any release was created, false otherwise. This should be the right option compared to the previous attempt that used release_created which is only true if a root component release was created, false otherwise. Thanks for the tip @pichlermarc ! Hopefully this one works better. 🤞

@JamieDanielson JamieDanielson requested a review from a team April 26, 2024 22:14
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (dfb2dff) to head (ea228af).
Report is 91 commits behind head on main.

❗ Current head ea228af differs from pull request most recent head fe6da36. Consider uploading reports for the commit fe6da36 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2160      +/-   ##
==========================================
- Coverage   90.97%   90.45%   -0.53%     
==========================================
  Files         146      147       +1     
  Lines        7492     7576      +84     
  Branches     1502     1574      +72     
==========================================
+ Hits         6816     6853      +37     
- Misses        676      723      +47     

see 25 files with indirect coverage changes

.github/workflows/release-please.yml Outdated Show resolved Hide resolved
.github/workflows/release-please.yml Outdated Show resolved Hide resolved
.github/workflows/release-please.yml Outdated Show resolved Hide resolved
@pichlermarc pichlermarc merged commit 394bb93 into open-telemetry:main Apr 29, 2024
13 checks passed
@JamieDanielson JamieDanielson deleted the jamie.fix-publish-step-take-2 branch April 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] newly created packages are published before the release PR is merged
4 participants