Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-instrumentation-node): add options for serviceinstance #2158

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add service instance ID detector to the list of possible detector on auto instrumentation for node

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (dfb2dff) to head (6c1c1ab).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2158      +/-   ##
==========================================
- Coverage   90.97%   90.47%   -0.50%     
==========================================
  Files         146      147       +1     
  Lines        7492     7593     +101     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6870      +54     
- Misses        676      723      +47     
Files Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.95% <100.00%> (+0.17%) ⬆️

... and 27 files with indirect coverage changes

@maryliag maryliag force-pushed the serv-id-env branch 2 times, most recently from 16dff9e to a231824 Compare April 26, 2024 13:41
@maryliag
Copy link
Contributor Author

maryliag commented Apr 26, 2024

Note: will wait for #2101 to get merged first, because the values on test will need to be updated to account for both changes.

@blumamir
Copy link
Member

Note: will wait for #2101 to get merged first, because the values on test will need to be updated to account for both changes.

Thanks @maryliag , #2101 is merged, and I think this one is ready to merge as well after you apply the update to tests🙏

@maryliag
Copy link
Contributor Author

Thanks @blumamir! I updated the tests

@blumamir blumamir merged commit 379b757 into open-telemetry:main Apr 29, 2024
17 checks passed
@dyladan dyladan mentioned this pull request Apr 29, 2024
@maryliag maryliag deleted the serv-id-env branch April 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants