Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/connect): use exported strings for attributes #2120

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Apr 19, 2024

Which problem is this PR solving?

Short description of the changes

On package examples/connect:

  • Update @opentelemetry/semantic-conventions to ^1.23.0
  • Use exported strings for Semantic Resource Attributes.

@maryliag maryliag requested a review from a team April 19, 2024 17:51
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Merging #2120 (4ce0b41) into main (dfb2dff) will decrease coverage by 0.63%.
Report is 64 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2120      +/-   ##
==========================================
- Coverage   90.97%   90.35%   -0.63%     
==========================================
  Files         146      147       +1     
  Lines        7492     7679     +187     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6938     +122     
- Misses        676      741      +65     

see 9 files with indirect coverage changes

@trentm trentm enabled auto-merge (squash) April 24, 2024 02:54
@trentm trentm disabled auto-merge April 24, 2024 06:32
Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <[email protected]>
@trentm
Copy link
Contributor

trentm commented Apr 24, 2024

Yo, github, wassup with the stuck in:

Checking for ability to merge automatically…
Hang in there while we check the branch’s status.

@trentm
Copy link
Contributor

trentm commented Apr 24, 2024

There was a GH incident that was resolved about 1h ago that might have been related: https://www.githubstatus.com/incidents/7txcg0j03kkg

I'm thinking of Leslie Lamport right now: “A distributed system is one in which the failure of a computer you didn't even know existed can render your own computer unusable”

@trentm
Copy link
Contributor

trentm commented Apr 24, 2024

Yo, github, wassup with the stuck in:

Checking for ability to merge automatically…
Hang in there while we check the branch’s status.

Back now.

@trentm trentm enabled auto-merge (squash) April 24, 2024 17:20
@trentm trentm merged commit 77452c1 into open-telemetry:main Apr 24, 2024
1 check passed
@maryliag maryliag deleted the examples-connect branch April 24, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants