fix(host-metrics): macOS bundling fix

packages/opentelemetry-host-metrics/README.md

@@ -39,6 +39,39 @@ const hostMetrics = new HostMetrics({ meterProvider, name: 'example-host-metrics
 hostMetrics.start();
 ```
 
+## Semantic Conventions
+
+This package uses Semantic Conventions [Version 1.25.0](https://github.com/open-telemetry/semantic-conventions/tree/v1.25.0/docs/system).
+As for now the Semantic Conventions are bundled in this package but eventually will be imported from `@opentelemetry/semantic-conventions` package when it is updated to latest version.
+Ref: [opentelemetry-js/issues/4235](https://github.com/open-telemetry/opentelemetry-js/issues/4235)
+
+Metrics collected:
+
+| Metric                      | Short Description                                         | Notes |
+| --------------------------- | --------------------------------------------------------- | ----- |
+| `system.cpu.time`           | Seconds each logical CPU spent on each mode               |       |
+| `system.cpu.utilization`    | Difference in system.cpu.time since the last measurement  |       |
+| `system.memory.usage`       | Reports memory in use by state                            |       |
+| `system.memory.utilization` |                                                           |       |
+| `system.network.dropped`    | Count of packets that are dropped                         |       |
+| `system.network.errors`     | Count of network errors detected                          |       |
+| `system.network.io`         |                                                           |       |
+| `process.cpu.time`          | Total CPU seconds                                         |       |
+| `process.cpu.utilization`   | Difference in process.cpu.time since the last measurement |       |
+| `process.memory.usage`      | The amount of physical memory in use                      |       |
+
+Attributes collected:
+
+| Metric                      | Short Description                  | Notes |
+| --------------------------- | ---------------------------------- | ----- |
+| `system.cpu.logical_number` | The logical CPU number             |       |
+| `system.cpu.state`          | The state of the CPU               |       |
+| `system.memory.state`       | The memory state                   |       |
+| `system.device`             | The device identifier              |       |
+| `network.io.direction`      | The network IO operation direction |       |
+| `system.network.state`      | The network state                  |       |
+| `process.cpu.state`         | The CPU state                      |       |
+
 ## Useful links
 
 * For more information on OpenTelemetry, visit: <https://opentelemetry.io/>

packages/opentelemetry-host-metrics/global.d.ts

@@ -0,0 +1,3 @@
+declare module 'systeminformation/lib/network' {
+  export { networkStats } from 'systeminformation';
+}

packages/opentelemetry-host-metrics/package.json

@@ -56,7 +56,7 @@
   },
   "dependencies": {
     "@opentelemetry/sdk-metrics": "^1.8.0",
-    "systeminformation": "^5.21.20"
+    "systeminformation": "^5.22.7"
   },
   "homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/opentelemetry-host-metrics#readme"
-}
+}

packages/opentelemetry-host-metrics/src/BaseMetrics.ts

@@ -14,8 +14,8 @@
  * limitations under the License.
  */
 
-import * as api from '@opentelemetry/api';
-import * as metrics from '@opentelemetry/sdk-metrics';
+import { Meter, diag, metrics } from '@opentelemetry/api';
+import { MeterProvider } from '@opentelemetry/sdk-metrics';
 
 import { VERSION } from './version';
 
@@ -24,7 +24,7 @@ import { VERSION } from './version';
  */
 export interface MetricsCollectorConfig {
   // Meter Provider
-  meterProvider?: metrics.MeterProvider;
+  meterProvider?: MeterProvider;
   // Character to be used to join metrics - default is "."
   metricNameSeparator?: string;
   // Name of component
@@ -39,14 +39,14 @@ const DEFAULT_NAME = '@opentelemetry/host-metrics';
  * Base Class for metrics
  */
 export abstract class BaseMetrics {
-  protected _logger = api.diag;
-  protected _meter: api.Meter;
+  protected _logger = diag;
+  protected _meter: Meter;
   private _name: string;
 
   constructor(config: MetricsCollectorConfig) {
     this._name = config.name || DEFAULT_NAME;
     const meterProvider =
-      config.meterProvider || api.metrics.getMeterProvider();
+      config.meterProvider || metrics.getMeterProvider();
     if (!config.meterProvider) {
       this._logger.warn('No meter provider, using default');
     }

packages/opentelemetry-host-metrics/src/enum.ts

@@ -32,11 +32,9 @@ export enum ATTRIBUTE_NAMES {
   SYSTEM_CPU_STATE = 'system.cpu.state',
   SYSTEM_MEMORY_STATE = 'system.memory.state',
   SYSTEM_DEVICE = 'system.device',
-  SYSTEM_NETWORK_DIRECTION = 'system.network.direction',
+  NETWORK_NETWORK_DIRECTION = 'network.io.direction',
   SYSTEM_NETWORK_STATE = 'system.network.state',
-  // TODO: change value if semconv changes
-  // https://github.com/open-telemetry/opentelemetry-specification/issues/3776
-  PROCESS_CPU_STATE = 'state',
+  PROCESS_CPU_STATE = 'process.cpu.state',
 }
 
 export enum CPU_LABELS {