Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mongodb-example): Ensure instrumentation is setup before mongoDB client is imported #1851

Merged
merged 3 commits into from
Jan 13, 2024

Conversation

NicholasGWK
Copy link
Contributor

Which problem is this PR solving?

  • I tried running the example, and wasn't actually getting any db info.
  • I ran diag logging, and it said the MongoDB client was being imported before instrumentation was setup
  • I reordered the imports, and got db spans!

Short description of the changes

  • Reorder imports so tracing setup is first

…client is import

I wasn't getting any MongoDB info, turned on diag logging and it warned the client was being imported before instrumentation was setup...reordered the imports and started to get spans!
@NicholasGWK NicholasGWK requested a review from a team December 7, 2023 22:20
Copy link

linux-foundation-easycla bot commented Dec 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: NicholasGWK / name: Nick Kennedy (9c6161e, 1f76c75)
  • ✅ login: blumamir / name: Amir Blum (3ab922d)

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Merging #1851 (3ab922d) into main (577a291) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   91.50%   91.50%           
=======================================
  Files         145      145           
  Lines        7425     7425           
  Branches     1484     1484           
=======================================
  Hits         6794     6794           
  Misses        631      631           

@blumamir blumamir merged commit c54e9b6 into open-telemetry:main Jan 13, 2024
15 checks passed
@dyladan dyladan mentioned this pull request Jan 13, 2024
@dyladan dyladan mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants