Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency mocha to v10 #1826

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency mocha to v10 #1826

wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 27, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
mocha (source) 7.2.0 -> 10.3.0 age adoption passing confidence
@types/mocha (source) 8.2.3 -> 10.0.6 age adoption passing confidence
@types/mocha (source) 7.0.2 -> 10.0.6 age adoption passing confidence
@types/mocha (source) ^7.0.2 -> ^10.0.0 age adoption passing confidence
@types/mocha (source) ^9.1.1 -> ^10.0.0 age adoption passing confidence
@types/mocha (source) 8.2.3 -> 10.0.6 age adoption passing confidence

Release Notes

mochajs/mocha (mocha)

v10.3.0

Compare Source

This is a stable release equivalent to 10.30.0-prerelease.

v10.2.0

Compare Source

🎉 Enhancements

🐛 Fixes

📖 Documentation

v10.1.0

Compare Source

🎉 Enhancements

🔩 Other

v10.0.0

Compare Source

💥 Breaking Changes

🔩 Other

Also thanks to @​ea2305 and @​SukkaW for improvements to our documentation.

v9.2.2

Compare Source

🐛 Fixes

🔩 Other

v9.2.1

Compare Source

🐛 Fixes

v9.2.0

Compare Source

🎉 Enhancements

🔩 Other

v9.1.4

Compare Source

🐛 Fixes

🔩 Other

v9.1.3

Compare Source

🐛 Fixes

🔩 Other

v9.1.2

Compare Source

🐛 Fixes

🔩 Other

v9.1.1

Compare Source

🐛 Fixes

v9.1.0

Compare Source

🎉 Enhancements

v9.0.3

Compare Source

🐛 Fixes

v9.0.2

Compare Source

🐛 Fixes

🔩 Other

v9.0.1

Compare Source

🔩 Other

We added a separate browser bundle mocha-es2018.js in javascript ES2018, as we skipped the transpilation down to ES5. This is an experimental step towards freezing Mocha's support of IE11.

v9.0.0

Compare Source

💥 Breaking Changes

Mocha is going ESM-first! This means that it will now use ESM import(test_file) to load the test files, instead of the CommonJS require(test_file). This is not a problem, as import can also load most files that require does. In the rare cases where this fails, it will fallback to require(...). This ESM-first approach is the next step in Mocha's ESM migration, and allows ESM loaders to load and transform the test file.

🎉 Enhancements

🐛 Fixes

🔩 Other

v8.4.0

Compare Source

🎉 Enhancements

🐛 Fixes

📖 Documentation

Also thanks to @​outsideris for various improvements on our GH actions workflows.

v8.3.2

Compare Source

🐛 Fixes

📖 Documentation

v8.3.1

Compare Source

🐛 Fixes

v8.3.0

Compare Source

🎉 Enhancements

🐛 Fixes

📖 Documentation

🔩 Other

Also thanks to @​outsideris and @​HyunSangHan for various fixes to our website and documentation.

v8.2.1

Compare Source

Fixed stuff.

🐛 Fixes

  • #​4489: Fix problematic handling of otherwise-unhandled Promise rejections and erroneous "done() called twice" errors (@​boneskull)
  • #​4496: Avoid MaxListenersExceededWarning in watch mode (@​boneskull)

Also thanks to @​akeating for a documentation fix!

v8.2.0

Compare Source

The major feature added in v8.2.0 is addition of support for global fixtures.

While Mocha has always had the ability to run setup and teardown via a hook (e.g., a before() at the top level of a test file) when running tests in serial, Mocha v8.0.0 added support for parallel runs. Parallel runs are incompatible with this strategy; e.g., a top-level before() would only run for the file in which it was defined.

With global fixtures, Mocha can now perform user-defined setup and teardown regardless of mode, and these fixtures are guaranteed to run once and only once. This holds for parallel mode, serial mode, and even "watch" mode (the teardown will run once you hit Ctrl-C, just before Mocha finally exits). Tasks such as starting and stopping servers are well-suited to global fixtures, but not sharing resources--global fixtures do not share context with your test files (but they do share context with each other).

Here's a short example of usage:

// fixtures.js

// can be async or not
exports.mochaGlobalSetup = async function() {
  this.server = await startSomeServer({port: process.env.TEST_PORT});
  console.log(`server running on port ${this.server.port}`);
};

exports.mochaGlobalTeardown = async function() {
  // the context (`this`) is shared, but not with the test files
  await this.server.stop();
  console.log(`server on port ${this.server.port} stopped`);
};

// this file can contain root hook plugins as well!
// exports.mochaHooks = { ... }

Fixtures are loaded with --require, e.g., mocha --require fixtures.js.

For detailed information, please see the documentation and this handy-dandy flowchart to help understand the differences between hooks, root hook plugins, and global fixtures (and when you should use each).

🎉 Enhancements

For implementors of custom reporters:

  • #​4409: Parallel mode and custom reporter improvements (@​boneskull):
    • Support custom worker-process-only reporters (Runner.prototype.workerReporter()); reporters should subclass ParallelBufferedReporter in mocha/lib/nodejs/reporters/parallel-buffered
    • Allow opt-in of object reference matching for "sufficiently advanced" custom reporters (Runner.prototype.linkPartialObjects()); use if strict object equality is needed when consuming Runner event data
    • Enable detection of parallel mode (Runner.prototype.isParallelMode())

🐛 Fixes

  • #​4476: Workaround for profoundly bizarre issue affecting npm v6.x causing some of Mocha's deps to be installed when mocha is present in a package's devDependencies and npm install --production is run the package's working copy (@​boneskull)
  • #​4465: Worker processes guaranteed (as opposed to "very likely") to exit before Mocha does; fixes a problem when using nyc with Mocha in parallel mode (@​boneskull)
  • #​4419: Restore lookupFiles() in mocha/lib/utils, which was broken/missing in Mocha v8.1.0; it now prints a deprecation warning (use const {lookupFiles} = require('mocha/lib/cli') instead) (@​boneskull)

Thanks to @​AviVahl, @​donghoon-song, @​ValeriaVG, @​znarf, @​sujin-park, and @​majecty for other helpful contributions!

v8.1.3

Compare Source

🐛 Fixes

  • #​4425: Restore Mocha.utils.lookupFiles() and Webpack compatibility (both broken since v8.1.0); Mocha.utils.lookupFiles() is now deprecated and will be removed in the next major revision of Mocha; use require('mocha/lib/cli').lookupFiles instead (@​boneskull)

v8.1.2

Compare Source

🐛 Fixes

🔒 Security Fixes

📖 Documentation

v8.1.1

Compare Source

🐛 Fixes

  • #​4394: Fix regression wherein certain reporters did not correctly detect terminal width (@​boneskull)

v8.1.0

Compare Source

In this release, Mocha now builds its browser bundle with Rollup and Babel, which will provide the project's codebase more flexibility and consistency.

While we've been diligent about backwards compatibility, it's possible consumers of the browser bundle will encounter differences (other than an increase in the bundle size). If you do encounter an issue with the build, please report it here.

This release does not drop support for IE11.

Other community contributions came from @​Devjeel, @​Harsha509 and @​sharath2106. Thank you to everyone who contributed to this release!

Do you read Korean? See this guide to running parallel tests in Mocha, translated by our maintainer, @​outsideris.

🎉 Enhancements

🐛 Fixes

🔒 Security Fixes

📖 Documentation & Website

🔩 Other

  • #​4293: Use Rollup and Babel in build pipeline; add source map to published files (@​Munter)

v8.0.1

Compare Source

The obligatory patch after a major.

🐛 Fixes

v8.0.0

Compare Source

In this major release, Mocha adds the ability to run tests in parallel. Better late than never! Please note the breaking changes detailed below.

Let's welcome @​giltayar and @​nicojs to the maintenance team!

💥 Breaking Changes

  • #​4164: Mocha v8.0.0 now requires Node.js v10.12.0 or newer. Mocha no longer supports the Node.js v8.x line ("Carbon"), which entered End-of-Life at the end of 2019 (@​UlisesGascon)

  • #​4175: Having been deprecated with a warning since v7.0.0, mocha.opts is no longer supported (@​juergba)

    ✨ WORKAROUND: Replace mocha.opts with a configuration file.

  • #​4260: Remove enableTimeout() (this.enableTimeout()) from the context object (@​craigtaub)

    ✨ WORKAROUND: Replace usage of this.enableTimeout(false) in your tests with this.timeout(0).

  • #​4315: The spec option no longer supports a comma-delimited list of files (@​juergba)

    ✨ WORKAROUND: Use an array instead (e.g., "spec": "foo.js,bar.js" becomes "spec": ["foo.js", "bar.js"]).

  • #​4309: Drop support for Node.js v13.x line, which is now End-of-Life (@​juergba)

  • #​4282: --forbid-only will throw an error even if exclusive tests are avoided via --grep or other means (@​arvidOtt)

  • #​4223: The context object's skip() (this.skip()) in a "before all" (before()) hook will no longer execute subsequent sibling hooks, in addition to hooks in child suites (@​juergba)

  • #​4178: Remove previously soft-deprecated APIs (@​wnghdcjfe):

    • Mocha.prototype.ignoreLeaks()
    • Mocha.prototype.useColors()
    • Mocha.prototype.useInlineDiffs()
    • Mocha.prototype.hideDiff()

🎉 Enhancements

📖 Documentation

🔩 Other

🐛 Fixes

(All bug fixes in Mocha v8.0.0 are also breaking changes, and are listed above)

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team November 27, 2023 09:07
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Nov 27, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2023 •
edited
Loading

Codecov Report

Merging #1826 (4fc011b) into main (dfb2dff) will increase coverage by 0.00%.
Report is 13 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage   90.97%   90.98%           
=======================================
  Files         146      145    -1     
  Lines        7492     7454   -38     
  Branches     1502     1488   -14     
=======================================
- Hits         6816     6782   -34     
+ Misses        676      672    -4

see 5 files with indirect coverage changes

@renovate-bot renovate-bot force-pushed the renovate/mocha-10.x branch 2 times, most recently from ed2d622 to 3e6af85 Compare December 22, 2023 08:47
@renovate-bot renovate-bot force-pushed the renovate/mocha-10.x branch 4 times, most recently from a68f312 to e1d7cc2 Compare February 29, 2024 09:25
@renovate-bot renovate-bot force-pushed the renovate/mocha-10.x branch 2 times, most recently from 697f526 to 59227e5 Compare March 6, 2024 08:46
@renovate-bot renovate-bot force-pushed the renovate/mocha-10.x branch 2 times, most recently from 1e42a84 to 1820755 Compare March 8, 2024 14:21
@pichlermarc
Copy link
Member

I realized that this is actually not really doing anything as ts-mocha will hold back mocha at 7.something.
I wonder if we even need ts-mocha. In my local testing adding a .mocharc in the repo top-level that registers ts-node/register and just using mocha directly works perfectly (at least in the core repo). Maybe we should try that out.

@forking-renovate Forking Renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 10.x releases. But if you manually upgrade to 10.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/mocha-10.x branch March 22, 2024 15:03
trentm added a commit to trentm/opentelemetry-js-contrib that referenced this pull request Oct 11, 2024
@trentm
chore: upgrade to mocha@10
c3c45a1 
From mocha@7. Drop use of ts-mocha in favour of a .mocharc.yml.
This mimicks the same mocha@10 update that was done in opentelemetry-js.git
a long while back.

Refs: open-telemetry#1826 (comment)
@trentm trentm mentioned this pull request Oct 11, 2024
Merged
trentm added a commit that referenced this pull request Oct 23, 2024
@trentm
chore: upgrade to mocha@10 (#2481)
d056d21 
From mocha@7. Drop use of ts-mocha in favour of a .mocharc.yml.
This mimicks the same mocha@10 update that was done in opentelemetry-js.git
a long while back.

- The mocha dep has been moved to the top-level and taken out of individual some-workspace/package.json files. I found that this workaround an npm layout issue where we would get many installs of mocha (one in each using workspace dir's own `node_modules/`). There is prior art: `eslint` deps are only at the top-level. 

Refs: #1826 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dyladan dyladan

@legendecas legendecas

@pichlermarc pichlermarc

@blumamir blumamir

Labels
dependencies Pull requests that update a dependency file pkg:auto-instrumentations-node pkg:auto-instrumentations-web pkg:host-metrics pkg:id-generator-aws-xray pkg:instrumentation-amqplib pkg:instrumentation-aws-lambda pkg:instrumentation-aws-sdk pkg:instrumentation-bunyan pkg:instrumentation-cassandra-driver pkg:instrumentation-connect pkg:instrumentation-cucumber pkg:instrumentation-dataloader pkg:instrumentation-dns pkg:instrumentation-document-load pkg:instrumentation-express pkg:instrumentation-fastify pkg:instrumentation-fs pkg:instrumentation-generic-pool pkg:instrumentation-graphql pkg:instrumentation-hapi pkg:instrumentation-ioredis pkg:instrumentation-knex pkg:instrumentation-koa pkg:instrumentation-long-task pkg:instrumentation-lru-memoizer pkg:instrumentation-memcached pkg:instrumentation-mongodb pkg:instrumentation-mongoose pkg:instrumentation-mysql pkg:instrumentation-mysql2 pkg:instrumentation-nestjs-core pkg:instrumentation-net pkg:instrumentation-pg pkg:instrumentation-pino pkg:instrumentation-redis pkg:instrumentation-redis-4 pkg:instrumentation-restify pkg:instrumentation-router pkg:instrumentation-runtime-node pkg:instrumentation-socket.io pkg:instrumentation-tedious pkg:instrumentation-user-interaction pkg:instrumentation-winston pkg:plugin-react-load pkg:propagation-utils pkg:propagator-instana pkg:propagator-ot-trace pkg:redis-common pkg:resource-detector-alibaba-cloud pkg:resource-detector-aws pkg:resource-detector-azure pkg:resource-detector-container pkg:resource-detector-gcp pkg:resource-detector-github pkg:resource-detector-instana pkg:sampler-aws-xray pkg:sql-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renovate-bot @pichlermarc @trentm @dyladan @legendecas @blumamir