feat(@opentelemetry/instrumentation-user-interaction): Add custom span attributes #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adamlyka
force-pushed
the
feat/user-interaction-add-custom-span-attributes
branch
3 times, most recently
from
9ffce41 to
1d5f45e
Compare
adamlyka
force-pushed
the
feat/user-interaction-add-custom-span-attributes
branch
from
1d5f45e to
a1368ae
Compare
|
As I mentioned on the issue, this is actually currently possible through the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#1770
Short description of the changes
Added the ability to add custom attributes on a span
I have set it up to be configured with a
UserInteractionCustomAttributeFunctionwhich is in the same fashion as the other plugins for consistency.