-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@opentelemetry/instrumentation-user-interaction): add event listeners for each event on init #1749
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
- Coverage 91.51% 91.03% -0.49%
==========================================
Files 145 134 -11
Lines 7427 6683 -744
Branches 1486 1333 -153
==========================================
- Hits 6797 6084 -713
+ Misses 630 599 -31 |
The behavior is intended to generate spans only for events that have handlers in the application code. The handlers in application code will generally invoke other work (e.g. HTTP requests), which then make the interactions more significant (longer duration, part of a bigger trace, applicable to application logic) than just tracking all events that happen on the page. If there is a use case to track all events, I would suggest we add a new instrumentation that does not rely on Zone.js. |
* Changes from relying on externally_connectable to CustomEvents (which will eventually work in Firefox) * Adds patch to @opentelemetry/instrumentation-user-interaction so specified event listeners are always registered, regardless of whether any other page code has already registered listeners (see: open-telemetry/opentelemetry-js-contrib#1749) * Adds .github workflow files for (some) CI/CD * Updates README.md
My understanding of this based on the description and Martin's comment above is this:
In that case I think it may be a feature instead of a bug fix, but I'm not super familiar with this instrumentation. Either way it seems this has been stalled for a bit. Is this update still something you're interested in moving forward @pkanal or is there another approach that is working for what you need? |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stale for 14 days with no activity. |
Which problem is this PR solving?
Short description of the changes