-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create an instrumentation package for ogma #1746
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 91.50% 91.47% -0.04%
==========================================
Files 145 144 -1
Lines 7431 7342 -89
Branches 1489 1466 -23
==========================================
- Hits 6800 6716 -84
+ Misses 631 626 -5
|
840509d
to
9abf5b1
Compare
Would I be able to request a review for this? Please and thank you |
9abf5b1
to
16e47ed
Compare
f104178
to
6d5ec8c
Compare
6b2a81a
to
aaebc90
Compare
6cc97c7
to
85e993e
Compare
I'm doing what I can top keep this PR active and current so it can be reviewed and merged when ready. Let me know if there's anything else that can be done here 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
cdd680e
to
3315307
Compare
3315307
to
a3b5692
Compare
Any updates? |
a3b5692
to
916d9e5
Compare
ff58f45
to
e5348bc
Compare
Hi @jmcdo29 usually there's an instrumentation request issue that should preceed a pull request adding a new instrumentation. Is there a reason why you decided to add this instrumentation here as opposed to hosting it in the ogma repo and adding it to the instrumentation registry? Usually we recommend that projects host their own instrumentations as it provides them with more control over the instrumentation. It also is easier for us as we're often not familiar with the library that's being instrumented. |
Adding native instrumentation might also be an option (directly depending on the |
I'm not opposed to hosting it in the ogma repo at all. Thanks for getting back to me on this. It seemed that adding the instrumentation to the repo was a "proper" way to go about it, but obviously any kind of hosted packages can work. I'll close this out and host it in my own repo as to not keep this open longer than it needs to be. Thanks. |
Which problem is this PR solving?
Short description of the changes
pino
instrumentation implementation, and modified it for how Ogma works. All tests should be passing, and I've assigned myself as the codeowner for this instrumentation. If there's anything else I need to do, please let me know, I'll be more than happy to do so