fix(instrumentation-redis-4): multi.exec patch should only throw error once #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r once this prevents undefined behaviour as it before this would throw two errors where the second one was seemingly impossible to catch
pichlermarc
added
bug
|
@trentm I'll close this as your PR appears to have a better fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents undefined behaviour as it before this would throw two errors where the second one was seemingly impossible to catch.
I'm unsure if this is the optimal approach, but it appears to function and I can't see that it would/has broken any existing functionality.
Which problem is this PR solving?
Fixes #1708
Short description of the changes
catchbranch to the return value of theexecpatch to prevent double errors