Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency sinon to v16 - autoclosed #1685

Closed

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sinon (source) 15.2.0 -> 16.1.3 age adoption passing confidence

Release Notes

sinonjs/sinon (sinon)

v16.1.3

Compare Source

  • 93e8aa93
    Remove postinstall script as it causes issues for consumers (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2023-10-19.

v16.1.2

Compare Source

  • 9ea3d5b2
    Fix hooks-install (Carl-Erik Kopseng)

Released by Carl-Erik Kopseng on 2023-10-19.

v16.1.1

Compare Source

Released by Carl-Erik Kopseng on 2023-10-18.

v16.1.0

Compare Source

  • cac5184b
    Enable use of assignment in the presence of accessors (#​2538) (Carl-Erik Kopseng)
  • f8c20e54
    New article: making Sinon work with complex setups (#​2540) (Carl-Erik Kopseng)

    Co-authored-by: Morgan Roderick [email protected] >

  • cb5b9621
    Add NPM script 'dev-docs' and document its usage (Carl-Erik Kopseng)
  • dd7c6091
    Add a little update to contributing (Carl-Erik Kopseng)
  • 79acdf38
    Move tool versions into single file at root (Carl-Erik Kopseng)
  • 03b1db50
    Expose Changelog page (#​2550) (Carl-Erik Kopseng)
  • e1c3dad2
    Add section on tooling and recommend using ASDF for tool versioning (#​2547) (Carl-Erik Kopseng)
    Released by Carl-Erik Kopseng on 2023-10-05.

v16.0.0

Compare Source

  • c3396058
    fix(2525): ensure non empty message when error of type string is passed, but no message (#​2544) (Mark de Dios)
  • baa1aee9
    .define method (#​2539) (Konstantin Gukov)
    • .define method for temporarily defining new properties during the tests
  • fe799e78
    Fix issue 2534: spies are not restored (#​2535) (Carl-Erik Kopseng)
  • 305fb6cc
    fix: actaully reset 'injectedKeys' (#​2456) (Morgan Roderick)
  • de2635dd
    Bump LTS version one notch: 20 (#​2529) (Carl-Erik Kopseng)

Released by Morgan Roderick on 2023-09-13.


Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team September 15, 2023 00:53
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #1685 (f91df25) into main (1dc2e81) will not change coverage.
The diff coverage is n/a.

❗ Current head f91df25 differs from pull request most recent head 354e295. Consider uploading reports for the commit 354e295 to get more accurate results

@@           Coverage Diff           @@
##             main    #1685   +/-   ##
=======================================
  Coverage   90.98%   90.98%           
=======================================
  Files         129      129           
  Lines        6448     6448           
  Branches     1296     1296           
=======================================
  Hits         5867     5867           
  Misses        581      581           

@blumamir
Copy link
Member

Syntax error in browser tests:


ERROR in ./node_modules/sinon/lib/sinon/sandbox.js 203:27
Module parse failed: Unexpected token (203:27)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| 
|         function restorer() {
>             if (descriptor?.isOwn) {
|                 Object.defineProperty(object, property, descriptor);
|             } else {
 @ ./node_modules/sinon/lib/sinon.js 8:16-42
 @ ./test/AWSXrayIdGenerator.test.ts
 @ ./test sync test$
 @ ./test/index-webpack.ts
npm ERR! code ELIFECYCLE
npm ERR! errno 1

@pichlermarc
Copy link
Member

Syntax error in browser tests:


ERROR in ./node_modules/sinon/lib/sinon/sandbox.js 203:27
Module parse failed: Unexpected token (203:27)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| 
|         function restorer() {
>             if (descriptor?.isOwn) {
|                 Object.defineProperty(object, property, descriptor);
|             } else {
 @ ./node_modules/sinon/lib/sinon.js 8:16-42
 @ ./test/AWSXrayIdGenerator.test.ts
 @ ./test sync test$
 @ ./test/index-webpack.ts
npm ERR! code ELIFECYCLE
npm ERR! errno 1

They removed support for node.js 14 in sinon v16 - it works with the node.js 14 tests because we're not using SinonSandbox there, which seems to be one of the first files to have dropped support. Looks like we won't be able to update unless we also drop support for node.js 14.

@renovate-bot renovate-bot changed the title chore(deps): update dependency sinon to v16 chore(deps): update dependency sinon to v16 - autoclosed Oct 20, 2023
@renovate-bot renovate-bot deleted the renovate/sinon-16.x branch October 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants